Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: update AUTHORS info for nstepien #45692

Merged
merged 1 commit into from
Nov 30, 2022
Merged

meta: update AUTHORS info for nstepien #45692

merged 1 commit into from
Nov 30, 2022

Conversation

nstepien
Copy link
Contributor

No description provided.

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Nov 30, 2022
@nstepien nstepien changed the title Update AUTHORS to use my name meta: Update AUTHORS to use my name Nov 30, 2022
@aduh95 aduh95 changed the title meta: Update AUTHORS to use my name meta: update AUTHORS info for nstepien Nov 30, 2022
@aduh95
Copy link
Contributor

aduh95 commented Nov 30, 2022

Can you add an entry in the .mailmap file, and then run tools/update-authors.mjs script? As is, this change would be overwritten the next time we run the script.
Optionally if you could amend the commit message so it complies with our guidelines (e.g. to meta: update AUTHORS info for nstepien) and force push, that'd be great – otherwise it can be done by whoever is landing the PR.

@nstepien
Copy link
Contributor Author

@aduh95 Done, thank you for your guidance.

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 30, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 30, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 30, 2022
@nodejs-github-bot nodejs-github-bot merged commit 2589fb1 into nodejs:main Nov 30, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 2589fb1

@nstepien nstepien deleted the patch-1 branch November 30, 2022 22:36
targos pushed a commit that referenced this pull request Dec 12, 2022
@nstepien @targos
meta: update AUTHORS info for nstepien
eb9a383 
PR-URL: #45692
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targos targos mentioned this pull request Dec 12, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@nstepien @danielleadams
meta: update AUTHORS info for nstepien
e5756c6 
PR-URL: #45692
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@nstepien @danielleadams
meta: update AUTHORS info for nstepien
db1be1d 
PR-URL: #45692
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@nstepien @danielleadams
meta: update AUTHORS info for nstepien
775f659 
PR-URL: #45692
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 4, 2023
@nstepien @danielleadams
meta: update AUTHORS info for nstepien
f36df8e 
PR-URL: #45692
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
@nstepien @danielleadams
meta: update AUTHORS info for nstepien
a55d1e8 
PR-URL: #45692
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nstepien @aduh95 @nodejs-github-bot @Trott @lpinca