Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v16.x backport] buffer: introduce File #45764

Closed

Conversation

ThisIsMissEm
Copy link

This backports #45139 to Node.js 16.x, with some minor caveats. See: #45763 for details.

KhafraDev and others added 2 commits December 6, 2022 23:06
PR-URL: nodejs#45139
Fixes: nodejs#39015
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v16.x labels Dec 6, 2022
@aduh95 aduh95 changed the title Backport File API to v16.x [v16.x backport] buffer: introduce File Dec 7, 2022
@richardlau
Copy link
Member

Given this is a feature for Node.js 16 I'm going to close this as wont-land on v16.x (Node.js 16 reaches End-of-Life in a few weeks on 11 September 2023). Comments in #45763 (comment) suggest a workaround using undici.

@richardlau richardlau closed this Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants