-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix test-net-happy-eyeballs
without IPv6 support
#45856
test: fix test-net-happy-eyeballs
without IPv6 support
#45856
Conversation
@LiviaMedeiros This looks fine to me in general. What happens for other platforms? |
I didn't test it but from my understanding of If there is any uncertainty, might be better to skip those assertions. |
Judging from CI results, I was wrong and the test can produce both Unless we really need to check the error, skipping that part. |
This comment was marked as outdated.
This comment was marked as outdated.
a117b3f
to
5a2e778
Compare
Failed to start CI- Validating Jenkins credentials ✖ Jenkins credentials invalidhttps://github.com/nodejs/node/actions/runs/4141827344 |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Landed in 109545a |
PR-URL: #45856 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>
PR-URL: #45856 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>
@LiviaMedeiros this broke tests when pulling into v18.x - do you mind opening a backport PR? |
PR-URL: nodejs#45856 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>
@danielleadams opened #47447 |
PR-URL: nodejs#45856 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>
With #49016, this can be landed on v18.x. |
PR-URL: #45856 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>
The error observed on linux-6.1.0 with disabled
CONFIG_IPV6
isEAFNOSUPPORT
.cc @ShogunPanda in case of any of:
Confirmed, checking both errors.EADDRNOTAVAIL
is confirmed to be thrown on any other platform: in this case, it would make sense to simply leave the error unchecked.undefined:undefined
is not what should appear in error message: in this case, we probably need a fallback toDEFAULT_IPV4_ADDR
/DEFAULT_IPV6_ADDR
atnode/lib/net.js
Line 1040 in cf0a42c