-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto: fix remaining WebCryptoAPI idlharness WPTs #45857
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
nodejs-github-bot
added
crypto
Issues and PRs related to the crypto subsystem.
needs-ci
PRs that need a full CI run.
labels
Dec 14, 2022
panva
added
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
dont-land-on-v16.x
dont-land-on-v18.x
PRs that should not land on the v18.x-staging branch and should not be released in v18.x.
and removed
dont-land-on-v16.x
dont-land-on-v18.x
PRs that should not land on the v18.x-staging branch and should not be released in v18.x.
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
labels
Dec 14, 2022
panva
force-pushed
the
fix-cryptokey-prototype
branch
from
December 16, 2022 13:24
840aac6
to
b5e59e3
Compare
panva
added
request-ci
Add this label to start a Jenkins CI on a PR.
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
and removed
request-ci
Add this label to start a Jenkins CI on a PR.
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
labels
Dec 16, 2022
panva
force-pushed
the
fix-cryptokey-prototype
branch
from
December 16, 2022 19:56
b5e59e3
to
b9a06a0
Compare
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Dec 16, 2022
This comment was marked as outdated.
This comment was marked as outdated.
panva
added
the
commit-queue-rebase
Add this label to allow the Commit Queue to land a PR in several commits.
label
Dec 16, 2022
panva
changed the title
crypto: fix CryptoKey prototype WPT
crypto: fix remaining WebCryptoAPI idlharness WPTs
Dec 16, 2022
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
aduh95
reviewed
Dec 17, 2022
panva
force-pushed
the
fix-cryptokey-prototype
branch
from
December 17, 2022 19:31
d864774
to
dc6e9a8
Compare
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Dec 20, 2022
Landed in 7738844...3f3966c |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Dec 20, 2022
PR-URL: #45857 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Dec 20, 2022
PR-URL: #45857 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Dec 20, 2022
PR-URL: #45857 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Dec 21, 2022
targos
pushed a commit
that referenced
this pull request
Jan 1, 2023
PR-URL: #45857 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jan 1, 2023
PR-URL: #45857 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jan 1, 2023
PR-URL: #45857 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 4, 2023
PR-URL: #45857 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 4, 2023
PR-URL: #45857 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 4, 2023
PR-URL: #45857 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 5, 2023
PR-URL: #45857 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 5, 2023
PR-URL: #45857 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 5, 2023
PR-URL: #45857 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Depends on #45659 |
juanarbol
added
the
backport-blocked-v18.x
PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport.
label
Jan 22, 2023
aduh95
added
dont-land-on-v14.x
dont-land-on-v18.x
PRs that should not land on the v18.x-staging branch and should not be released in v18.x.
and removed
backport-blocked-v18.x
PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport.
labels
Jan 23, 2023
juanarbol
pushed a commit
that referenced
this pull request
Jan 26, 2023
PR-URL: #45857 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue-rebase
Add this label to allow the Commit Queue to land a PR in several commits.
crypto
Issues and PRs related to the crypto subsystem.
dont-land-on-v18.x
PRs that should not land on the v18.x-staging branch and should not be released in v18.x.
needs-ci
PRs that need a full CI run.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
Cryptokey
to be just a non-constructable wrapper, not having any of the transferable related getters, moving those toInternalCryptoKey
.JSTransferable remains in effect, but will rebase and run ci after #45811 lands to reconfirm (done).
Also fixes (adds)
globalThis.crypto
this
check.