test: use process.hrtime.bigint instead of process.hrtime
#45877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
deokjinkim
force-pushed
the
221216_use_hrtime_bigint
branch
from
b347bf0 to
ea38ffc
Compare
`process.hrtime` is legacy. So replace `process.hrtime` with `process.hrtime.bigint` in test. Refs: https://github.com/nodejs/node/blob/main/doc/api/process.md#processhrtimetime Signed-off-by: Deokjin Kim <deokjin81.kim@gmail.com>
deokjinkim
force-pushed
the
221216_use_hrtime_bigint
branch
from
ea38ffc to
6b0e8d6
Compare
aduh95
reviewed
Dec 16, 2022
| @@ -5,6 +5,8 @@ if (!common.hasCrypto) | |||
| common.skip('missing crypto'); | |||
| const assert = require('assert'); | |||
| const http2 = require('http2'); | |||
| const hrtime = process.hrtime.bigint; | |||
| const NS_PER_MS = 1000000n; | |||
There was a problem hiding this comment.
Suggested change
| const NS_PER_MS = 1000000n; | |
| const NS_PER_MS = 1_000_000n; |
There was a problem hiding this comment.
Applied your suggestion. Thank you for suggestion.
github-actions
bot
removed
the
request-ci
This was referenced Dec 18, 2022
jasnell
approved these changes
Dec 19, 2022
aduh95
approved these changes
Dec 19, 2022
aduh95
added
the
author ready
This was referenced Dec 20, 2022
targos
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/45877 ✔ Done loading data for nodejs/node/pull/45877 ----------------------------------- PR info ------------------------------------ Title test: use `process.hrtime.bigint` instead of `process.hrtime` (#45877) Author Deokjin Kim (@deokjinkim) Branch deokjinkim:221216_use_hrtime_bigint -> nodejs:main Labels test, author ready, needs-ci Commits 2 - test: use `process.hrtime.bigint` instead of `process.hrtime` - Revise format of NS_PER_MS Committers 1 - Deokjin Kim PR-URL: https://github.com/nodejs/node/pull/45877 Refs: https://github.com/nodejs/node/blob/main/doc/api/process.md#processhrtimetime Refs: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt Reviewed-By: James M Snell Reviewed-By: Antoine du Hamel ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/45877 Refs: https://github.com/nodejs/node/blob/main/doc/api/process.md#processhrtimetime Refs: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt Reviewed-By: James M Snell Reviewed-By: Antoine du Hamel -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 16 Dec 2022 04:30:59 GMT ✔ Approvals: 2 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/45877#pullrequestreview-1223228434 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/45877#pullrequestreview-1223230198 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-12-28T11:55:39Z: https://ci.nodejs.org/job/node-test-pull-request/48749/ - Querying data for job/node-test-pull-request/48749/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 45877 From https://github.com/nodejs/node * branch refs/pull/45877/merge -> FETCH_HEAD ✔ Fetched commits as 5e43f3d77694..ecc7caabeb39 -------------------------------------------------------------------------------- [main 3232ff220d] test: use `process.hrtime.bigint` instead of `process.hrtime` Author: Deokjin Kim Date: Fri Dec 16 13:27:05 2022 +0900 1 file changed, 10 insertions(+), 8 deletions(-) [main 89e27a7a55] Revise format of NS_PER_MS Author: Deokjin Kim Date: Sat Dec 17 02:56:22 2022 +0900 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/3816511183 |
targos
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 4b9f94b |
targos
pushed a commit
that referenced
this pull request
Jan 1, 2023
`process.hrtime` is legacy. So replace `process.hrtime` with `process.hrtime.bigint` in test. Refs: https://github.com/nodejs/node/blob/main/doc/api/process.md#processhrtimetime Signed-off-by: Deokjin Kim <deokjin81.kim@gmail.com> PR-URL: #45877 Refs: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 4, 2023
`process.hrtime` is legacy. So replace `process.hrtime` with `process.hrtime.bigint` in test. Refs: https://github.com/nodejs/node/blob/main/doc/api/process.md#processhrtimetime Signed-off-by: Deokjin Kim <deokjin81.kim@gmail.com> PR-URL: #45877 Refs: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 5, 2023
`process.hrtime` is legacy. So replace `process.hrtime` with `process.hrtime.bigint` in test. Refs: https://github.com/nodejs/node/blob/main/doc/api/process.md#processhrtimetime Signed-off-by: Deokjin Kim <deokjin81.kim@gmail.com> PR-URL: #45877 Refs: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
juanarbol
pushed a commit
that referenced
this pull request
Jan 26, 2023
`process.hrtime` is legacy. So replace `process.hrtime` with `process.hrtime.bigint` in test. Refs: https://github.com/nodejs/node/blob/main/doc/api/process.md#processhrtimetime Signed-off-by: Deokjin Kim <deokjin81.kim@gmail.com> PR-URL: #45877 Refs: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Jan 31, 2023
`process.hrtime` is legacy. So replace `process.hrtime` with `process.hrtime.bigint` in test. Refs: https://github.com/nodejs/node/blob/main/doc/api/process.md#processhrtimetime Signed-off-by: Deokjin Kim <deokjin81.kim@gmail.com> PR-URL: #45877 Refs: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
process.hrtimeis legacy. So replaceprocess.hrtimewithprocess.hrtime.bigintin test.Refs: https://github.com/nodejs/node/blob/main/doc/api/process.md#processhrtimetime
Refs: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt
Signed-off-by: Deokjin Kim deokjin81.kim@gmail.com