Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add backticks to webcrypto rsaOaepParams #45883

Merged
merged 1 commit into from
Dec 16, 2022
Merged

doc: add backticks to webcrypto rsaOaepParams #45883

merged 1 commit into from
Dec 16, 2022

Conversation

panva
Copy link
Member

@panva panva commented Dec 16, 2022 •
edited
Loading

Adds missing backticks to rsaOaepParams members to fix the below

Screenshot 2022-12-16 at 12 03 51

Screenshot 2022-12-16 at 12 03 42

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Dec 16, 2022
@lpinca lpinca added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 16, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @lpinca. Please 👍 to approve.

@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Dec 16, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 16, 2022
@nodejs-github-bot nodejs-github-bot merged commit 464e4d2 into nodejs:main Dec 16, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 464e4d2

@panva panva deleted the doc-rsa-oaep-params branch December 16, 2022 16:56
targos pushed a commit that referenced this pull request Jan 1, 2023
@panva @targos
doc: add backticks to webcrypto rsaOaepParams
e229f06 
PR-URL: #45883
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jan 2, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
@panva @juanarbol
doc: add backticks to webcrypto rsaOaepParams
48ea28a 
PR-URL: #45883
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@juanarbol juanarbol mentioned this pull request Jan 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

@aduh95 aduh95 aduh95 approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@panva @nodejs-github-bot @lpinca @aduh95 @RaisinTen