net: handle socket.write(cb) edge case #45922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
addaleax
approved these changes
Dec 20, 2022
cjihrig
approved these changes
Dec 20, 2022
lpinca
reviewed
Dec 20, 2022
| const server = net.createServer(); | ||
| server.listen(0, common.mustCall(() => { | ||
| const socket = new net.Socket(); | ||
|
|
There was a problem hiding this comment.
Suggested change
| socket.on('connect', common.mustNotCall()); | |
| assert(socket.connecting); | ||
|
|
||
| socket.write('foo', common.expectsError({ | ||
| code: 'ERR_SOCKET_CLOSED', |
There was a problem hiding this comment.
I think this error is a bit misleading. The socket is not closed when socket.write() is called. I think an error like "The socket was closed before the connection was established" would be be better. Anyway this is not a blocker.
| @@ -0,0 +1,24 @@ | |||
| 'use strict'; | |||
There was a problem hiding this comment.
Can you append -before-connect to the test file name?
JungMinu
approved these changes
Dec 21, 2022
ShogunPanda
approved these changes
Dec 21, 2022
santigimeno
force-pushed
the
santi/fix_30841
branch
from
3c5e0af
to
1aa5e97
Compare
|
@lpinca I think I addressed your comments. PTAL. Thanks |
lpinca
approved these changes
Dec 27, 2022
Make sure that when calling `write()` on a connecting socket, the callback is called if the socket is destroyed before the connection is established. Fixes: nodejs#30841
santigimeno
force-pushed
the
santi/fix_30841
branch
from
1aa5e97
to
62ef1e5
Compare
lpinca
approved these changes
Dec 27, 2022
github-actions
bot
removed
the
request-ci
mcollina
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in a03529d |
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 2, 2023
Make sure that when calling `write()` on a connecting socket, the callback is called if the socket is destroyed before the connection is established. Fixes: #30841 PR-URL: #45922 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 4, 2023
Make sure that when calling `write()` on a connecting socket, the callback is called if the socket is destroyed before the connection is established. Fixes: #30841 PR-URL: #45922 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 5, 2023
Make sure that when calling `write()` on a connecting socket, the callback is called if the socket is destroyed before the connection is established. Fixes: #30841 PR-URL: #45922 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
juanarbol
pushed a commit
that referenced
this pull request
Jan 26, 2023
Make sure that when calling `write()` on a connecting socket, the callback is called if the socket is destroyed before the connection is established. Fixes: #30841 PR-URL: #45922 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Jan 31, 2023
Make sure that when calling `write()` on a connecting socket, the callback is called if the socket is destroyed before the connection is established. Fixes: #30841 PR-URL: #45922 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that when calling
write()on a connecting socket, the callback is called if the socket is destroyed before the connection is established.Fixes: #30841