-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix wrong output of example in url.password
#45928
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
deokjinkim:221221_fix_wrong_output_url_password
Dec 21, 2022
Merged
doc: fix wrong output of example in url.password
#45928
nodejs-github-bot
merged 1 commit into
nodejs:main
from
deokjinkim:221221_fix_wrong_output_url_password
Dec 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tailing slash of url.href is ommited.
nodejs-github-bot
added
doc
Issues and PRs related to the documentations.
url
Issues and PRs related to the legacy built-in url module.
labels
Dec 21, 2022
aduh95
approved these changes
Dec 21, 2022
aduh95
added
fast-track
PRs that do not need to wait for 48 hours to land.
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
labels
Dec 21, 2022
Fast-track has been requested by @aduh95. Please 👍 to approve. |
cjihrig
approved these changes
Dec 21, 2022
aduh95
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Dec 21, 2022
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Dec 21, 2022
Landed in f3dd3fe |
targos
pushed a commit
that referenced
this pull request
Jan 1, 2023
Tailing slash of url.href is ommited. PR-URL: #45928 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 4, 2023
Tailing slash of url.href is ommited. PR-URL: #45928 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 5, 2023
Tailing slash of url.href is ommited. PR-URL: #45928 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
juanarbol
pushed a commit
that referenced
this pull request
Jan 26, 2023
Tailing slash of url.href is ommited. PR-URL: #45928 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Jan 31, 2023
Tailing slash of url.href is ommited. PR-URL: #45928 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
fast-track
PRs that do not need to wait for 48 hours to land.
url
Issues and PRs related to the legacy built-in url module.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tailing slash of url.href is ommited.