Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: add nodejs/test_runner to CODEOWNERS #45935

Merged
merged 1 commit into from
Dec 23, 2022
Merged

meta: add nodejs/test_runner to CODEOWNERS #45935

merged 1 commit into from
Dec 23, 2022

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Dec 21, 2022

/cc @nodejs/test_runner

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Dec 21, 2022
ljharb
ljharb approved these changes Dec 21, 2022
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why it’s complaining about the tsc team

@aduh95
Copy link
Contributor Author

aduh95 commented Dec 21, 2022

not sure why it’s complaining about the tsc team

It's complaining about all the teams x) I think it expects to find individual accounts instead of teams, but it's OK to ignore as it's just a warning.

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 21, 2022
@richardlau
Copy link
Member

not sure why it’s complaining about the tsc team

It's complaining about all the teams x) I think it expects to find individual accounts instead of teams, but it's OK to ignore as it's just a warning.

See the discussion in #33984. We haven't explicitly given most teams (including the tsc) write access to this repository -- most people with write access to this repository gain that permission via the collaborators team (which has been explicitly given permission to write to this repository). There was a suggestion about reorganising our teams hierarchy but in the end we went for an approach using our github-bot to implement pinging appropriate teams.

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 21, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 23, 2022
@nodejs-github-bot nodejs-github-bot merged commit f8bc4ce into nodejs:main Dec 23, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in f8bc4ce

targos pushed a commit that referenced this pull request Jan 1, 2023
@aduh95 @targos
meta: add nodejs/test_runner to CODEOWNERS
54d31f1 
PR-URL: #45935
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jan 2, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Jan 4, 2023
@aduh95 @RafaelGSS
meta: add nodejs/test_runner to CODEOWNERS
2b4ef45 
PR-URL: #45935
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
RafaelGSS pushed a commit that referenced this pull request Jan 5, 2023
@aduh95 @RafaelGSS
meta: add nodejs/test_runner to CODEOWNERS
e956956 
PR-URL: #45935
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
@aduh95 @juanarbol
meta: add nodejs/test_runner to CODEOWNERS
6539fb2 
PR-URL: #45935
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@juanarbol juanarbol mentioned this pull request Jan 28, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
@aduh95 @juanarbol
meta: add nodejs/test_runner to CODEOWNERS
56247d7 
PR-URL: #45935
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@legendecas legendecas legendecas approved these changes

@MoLow MoLow MoLow approved these changes

@richardlau richardlau richardlau approved these changes

@benjamingr benjamingr benjamingr approved these changes

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@aduh95 @nodejs-github-bot @richardlau @ljharb @GeoffreyBooth @benjamingr @MoLow @legendecas @RafaelGSS @RaisinTen