[DRAFT] test_runner: no skip diagnose on warning message #46027
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
dont-land-on-v14.x
needs-ci
MrJithil
changed the title
MrJithil
force-pushed
the
avoidSkipDiagnoWarns
branch
2 times, most recently
from
8abd54e
to
947cee5
Compare
test_runner: no skip diagnose on warning message
MrJithil
force-pushed
the
avoidSkipDiagnoWarns
branch
from
947cee5
to
905af31
Compare
|
I am not sure regarding this solution and weather it is robust enough |
|
I would prefer a solution that knows what diagnostic messages to ignore, rather than what shouln't |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_runner: no skip diagnose on warning message
#45910