Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: only include http module once #4606

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 10, 2016

A few tests in test/gc include the http module twice. Remove duplicate
require().

A few tests in test/gc include the http module twice. Remove duplicate
require().
@Trott Trott added http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests. labels Jan 10, 2016
@mscdex
Copy link
Contributor

mscdex commented Jan 10, 2016

LGTM

@Trott
Copy link
Member Author

Trott commented Jan 10, 2016

@targos
Copy link
Member

targos commented Jan 10, 2016

LGTM

1 similar comment
@cjihrig
Copy link
Contributor

cjihrig commented Jan 10, 2016

LGTM

@jasnell
Copy link
Member

jasnell commented Jan 11, 2016

LGTM

jasnell pushed a commit that referenced this pull request Jan 11, 2016
A few tests in test/gc include the http module twice. Remove duplicate
require().

PR-URL: #4606
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Jan 11, 2016

Landed in 521f51a

@jasnell jasnell closed this Jan 11, 2016
MylesBorins pushed a commit that referenced this pull request Jan 11, 2016
A few tests in test/gc include the http module twice. Remove duplicate
require().

PR-URL: #4606
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 11, 2016
MylesBorins pushed a commit that referenced this pull request Jan 12, 2016
A few tests in test/gc include the http module twice. Remove duplicate
require().

PR-URL: #4606
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 28, 2016
A few tests in test/gc include the http module twice. Remove duplicate
require().

PR-URL: #4606
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 11, 2016
A few tests in test/gc include the http module twice. Remove duplicate
require().

PR-URL: #4606
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Feb 11, 2016
A few tests in test/gc include the http module twice. Remove duplicate
require().

PR-URL: nodejs#4606
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 11, 2016
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Feb 15, 2016
A few tests in test/gc include the http module twice. Remove duplicate
require().

PR-URL: nodejs#4606
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
A few tests in test/gc include the http module twice. Remove duplicate
require().

PR-URL: nodejs#4606
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott Trott deleted the require-http-once branch January 13, 2022 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants