Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream: remove useless if test in transform #4617

Closed
wants to merge 1 commit into from

Conversation

zoubin
Copy link
Contributor

@zoubin zoubin commented Jan 11, 2016

@silverwind silverwind added the stream Issues and PRs related to the stream subsystem. label Jan 11, 2016
@silverwind
Copy link
Contributor

LGTM

2 similar comments
@cjihrig
Copy link
Contributor

cjihrig commented Jan 11, 2016

LGTM

@mscdex
Copy link
Contributor

mscdex commented Jan 11, 2016

LGTM

silverwind pushed a commit that referenced this pull request Jan 11, 2016
PR-URL: #4617
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
@silverwind
Copy link
Contributor

Thanks! Landed in ce9c93c.

@silverwind silverwind closed this Jan 11, 2016
MylesBorins pushed a commit that referenced this pull request Jan 11, 2016
PR-URL: #4617
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
@MylesBorins MylesBorins mentioned this pull request Jan 11, 2016
MylesBorins pushed a commit that referenced this pull request Jan 12, 2016
PR-URL: #4617
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
@rvagg
Copy link
Member

rvagg commented Jan 18, 2016

Thanks for fix @zoubin, I believe this is your first commit to core, if so, welcome on board! I hope you stick around and can other places to contribute.

@zoubin
Copy link
Contributor Author

zoubin commented Jan 18, 2016

@rvagg Glad to make contributions. I'll be watching this repo from now on.

MylesBorins pushed a commit that referenced this pull request Jan 28, 2016
PR-URL: #4617
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
MylesBorins pushed a commit that referenced this pull request Feb 11, 2016
PR-URL: #4617
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Feb 11, 2016
PR-URL: nodejs#4617
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
@MylesBorins MylesBorins mentioned this pull request Feb 11, 2016
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Feb 15, 2016
PR-URL: nodejs#4617
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
PR-URL: nodejs#4617
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stream Issues and PRs related to the stream subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants