Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v18.x backport] crypto: add KeyObject Symbol.toStringTag #46341

Closed
wants to merge 1 commit into from
Closed

[v18.x backport] crypto: add KeyObject Symbol.toStringTag #46341

wants to merge 1 commit into from

Conversation

panva
Copy link
Member

@panva panva commented Jan 24, 2023

Backports #46043, despite landing cleanly it would be missing ObjectDefineProperties from a previous commit that will not be backported.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@panva
crypto: add KeyObject Symbol.toStringTag
6f6cf28 
PR-URL: nodejs#46043
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Backport-PR-URL: nodejs#46341
@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. labels Jan 24, 2023
@panva panva marked this pull request as ready for review January 24, 2023 22:54
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 24, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 24, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@panva
Copy link
Member Author

panva commented Jan 24, 2023

cc @juanarbol

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49160/

@panva
Copy link
Member Author

panva commented Jan 28, 2023

It appears you've got this in v18.x-staging already. 👍 feel free to close as needed.

juanarbol
juanarbol approved these changes Jan 28, 2023
View reviewed changes
Copy link
Member

@juanarbol juanarbol left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juanarbol pushed a commit that referenced this pull request Jan 28, 2023
@panva @juanarbol
crypto: add KeyObject Symbol.toStringTag
20af657 
PR-URL: #46043
Backport-PR-URL: #46341
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@juanarbol
Copy link
Member

Landed in 20af657 🎉

@juanarbol juanarbol closed this Jan 28, 2023
@panva
Copy link
Member Author

panva commented Jan 28, 2023

@juanarbol it's just an empty commit now because you've already had it in staging somehow.

@panva panva deleted the backport-46043-to-v18.x branch January 28, 2023 20:50
@juanarbol
Copy link
Member

Sorry, same as #46340; I'll proceed to delete that 20af657 commit from staging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanarbol juanarbol juanarbol approved these changes

Assignees
No one assigned
Labels
crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@panva @nodejs-github-bot @juanarbol