Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: s390x zlib test case fixes #46367

Merged
merged 1 commit into from
Jan 28, 2023
Merged

test: s390x zlib test case fixes #46367

merged 1 commit into from
Jan 28, 2023

Conversation

AdamMajer
Copy link
Contributor

This is similar to #44117 and addresses the indeterminate nature of the hardware accelerated compression.

The fix looks kind of ugly but I wanted to keep the asserts the same.

@AdamMajer
test: s390x zlib test case fixes
25d69a6 
This is similar to nodejs#44117 and
addresses the indeterminate nature of the hardware accelerated
compression.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jan 26, 2023
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 26, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 26, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49199/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49215/

mhdawson
mhdawson approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 28, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 28, 2023
@nodejs-github-bot nodejs-github-bot merged commit 223dc69 into nodejs:main Jan 28, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 223dc69

ruyadorno pushed a commit that referenced this pull request Feb 1, 2023
@AdamMajer @ruyadorno
test: s390x zlib test case fixes
7385edc 
This is similar to #44117 and
addresses the indeterminate nature of the hardware accelerated
compression.

PR-URL: #46367
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@ruyadorno ruyadorno mentioned this pull request Feb 1, 2023
Merged
juanarbol pushed a commit that referenced this pull request Mar 3, 2023
@AdamMajer @juanarbol
test: s390x zlib test case fixes
4126b0c 
This is similar to #44117 and
addresses the indeterminate nature of the hardware accelerated
compression.

PR-URL: #46367
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@juanarbol juanarbol mentioned this pull request Mar 3, 2023
Merged
juanarbol pushed a commit that referenced this pull request Mar 3, 2023
@AdamMajer @juanarbol
test: s390x zlib test case fixes
2ff230a 
This is similar to #44117 and
addresses the indeterminate nature of the hardware accelerated
compression.

PR-URL: #46367
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
juanarbol pushed a commit that referenced this pull request Mar 5, 2023
@AdamMajer @juanarbol
test: s390x zlib test case fixes
9d40aef 
This is similar to #44117 and
addresses the indeterminate nature of the hardware accelerated
compression.

PR-URL: #46367
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AdamMajer @nodejs-github-bot @lpinca @mhdawson