Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test,crypto: add CFRG curve vectors to wrap/unwrap tests #46406

Merged
merged 1 commit into from
Jan 31, 2023
Merged

test,crypto: add CFRG curve vectors to wrap/unwrap tests #46406

merged 1 commit into from
Jan 31, 2023

Conversation

panva
Copy link
Member

@panva panva commented Jan 29, 2023

Adds tests for Ed25519, Ed448, X25519, and X448 wrapping/unwrapping.

@panva panva added crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to the tests. webcrypto labels Jan 29, 2023
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jan 29, 2023
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 29, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 29, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49227/

@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 29, 2023
@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 29, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 31, 2023
@nodejs-github-bot nodejs-github-bot merged commit c3b794e into nodejs:main Jan 31, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in c3b794e

@panva panva deleted the add-wrap-unwrap-cfrg-vectors branch January 31, 2023 14:55
ruyadorno pushed a commit that referenced this pull request Feb 1, 2023
@panva @ruyadorno
test,crypto: add CFRG curve vectors to wrap/unwrap tests
d13116a 
PR-URL: #46406
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Feb 1, 2023
Merged
juanarbol pushed a commit that referenced this pull request Mar 3, 2023
@panva @juanarbol
test,crypto: add CFRG curve vectors to wrap/unwrap tests
9785aae 
PR-URL: #46406
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@juanarbol juanarbol mentioned this pull request Mar 3, 2023
Merged
juanarbol pushed a commit that referenced this pull request Mar 3, 2023
@panva @juanarbol
test,crypto: add CFRG curve vectors to wrap/unwrap tests
c899cd6 
PR-URL: #46406
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
juanarbol pushed a commit that referenced this pull request Mar 5, 2023
@panva @juanarbol
test,crypto: add CFRG curve vectors to wrap/unwrap tests
c0d3fda 
PR-URL: #46406
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. webcrypto
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@panva @nodejs-github-bot @jasnell @tniessen