-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add note about major release rotation #46436
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
RafaelGSS:add-note-major-release-rotation
Feb 2, 2023
Merged
doc: add note about major release rotation #46436
nodejs-github-bot
merged 1 commit into
nodejs:main
from
RafaelGSS:add-note-major-release-rotation
Feb 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
mcollina
approved these changes
Jan 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
lpinca
approved these changes
Jan 31, 2023
mhdawson
approved these changes
Jan 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
RafaelGSS
force-pushed
the
add-note-major-release-rotation
branch
from
January 31, 2023 21:25
3f5cd28
to
bb6badf
Compare
GeoffreyBooth
approved these changes
Jan 31, 2023
ruyadorno
approved these changes
Jan 31, 2023
RafaelGSS
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Feb 2, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Feb 2, 2023
Landed in 6099637 |
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2023
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: #46436 Fixes: nodejs/Release#765 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: #46436 Fixes: nodejs/Release#765 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: nodejs/Release#765
cc: @nodejs/releasers