-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: predeclare Event.isTrusted property descriptor #46527
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
santigimeno:santi/event_descriptor
Feb 8, 2023
Merged
lib: predeclare Event.isTrusted property descriptor #46527
nodejs-github-bot
merged 1 commit into
nodejs:main
from
santigimeno:santi/event_descriptor
Feb 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpinca
approved these changes
Feb 6, 2023
anonrig
added
the
performance
Issues and PRs related to the performance of Node.js.
label
Feb 6, 2023
anonrig
approved these changes
Feb 6, 2023
anonrig
added
request-ci
Add this label to start a Jenkins CI on a PR.
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
labels
Feb 6, 2023
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Feb 6, 2023
mscdex
reviewed
Feb 6, 2023
UlisesGascon
approved these changes
Feb 6, 2023
santigimeno
force-pushed
the
santi/event_descriptor
branch
from
February 6, 2023 18:56
7e0185e
to
c64f53a
Compare
BridgeAR
approved these changes
Feb 6, 2023
aduh95
reviewed
Feb 6, 2023
It improves Event creation performance.
santigimeno
force-pushed
the
santi/event_descriptor
branch
from
February 6, 2023 19:49
c64f53a
to
2820ee9
Compare
aduh95
approved these changes
Feb 6, 2023
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Feb 6, 2023
jasnell
approved these changes
Feb 6, 2023
Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1294/ Results
|
cjihrig
approved these changes
Feb 7, 2023
aduh95
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Feb 7, 2023
RafaelGSS
approved these changes
Feb 8, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Feb 8, 2023
Landed in 85c8b78 |
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2023
It improves Event creation performance. PR-URL: #46527 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
It improves Event creation performance. PR-URL: #46527 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
needs-ci
PRs that need a full CI run.
performance
Issues and PRs related to the performance of Node.js.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It improves Event creation performance.
I'm seeing these numbers: