-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update ada to v1.0.1 #46550
Closed
Closed
deps: update ada to v1.0.1 #46550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Daniel Lemire <daniel@lemire.me>
anonrig
added
the
commit-queue-rebase
Add this label to allow the Commit Queue to land a PR in several commits.
label
Feb 7, 2023
nodejs-github-bot
added
dependencies
Pull requests that update a dependency file.
needs-ci
PRs that need a full CI run.
tools
Issues and PRs related to the tools directory.
labels
Feb 7, 2023
anonrig
added
request-ci
Add this label to start a Jenkins CI on a PR.
fast-track
PRs that do not need to wait for 48 hours to land.
labels
Feb 7, 2023
Fast-track has been requested by @anonrig. Please 👍 to approve. |
cc @nodejs/url |
github-actions
bot
added
request-ci-failed
An error occurred while starting CI via request-ci label, and manual interventon is needed.
and removed
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Feb 7, 2023
Failed to start CI- Validating Jenkins credentials ✖ Jenkins credentials invalidhttps://github.com/nodejs/node/actions/runs/4118887220 |
Ci has been locked for pending security release. It'll be released for use again tomorrow probably. |
jasnell
approved these changes
Feb 7, 2023
FYI The security releases are next Tuesday, 14 February. The CI will be locked down until at least then. |
tniessen
removed
fast-track
PRs that do not need to wait for 48 hours to land.
request-ci-failed
An error occurred while starting CI via request-ci label, and manual interventon is needed.
labels
Feb 8, 2023
cjihrig
approved these changes
Feb 8, 2023
Flarna
approved these changes
Feb 8, 2023
TimothyGu
approved these changes
Feb 9, 2023
aduh95
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Feb 12, 2023
TimothyGu
added
commit-queue
Add this label to land a pull request using GitHub Actions.
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
and removed
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue
Add this label to land a pull request using GitHub Actions.
labels
Feb 16, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Feb 17, 2023
Landed in 65854f1...8eb8e7a |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Feb 17, 2023
PR-URL: #46550 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Feb 17, 2023
Co-authored-by: Daniel Lemire <daniel@lemire.me> PR-URL: #46550 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
32 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2023
PR-URL: #46550 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2023
Co-authored-by: Daniel Lemire <daniel@lemire.me> PR-URL: #46550 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Feb 20, 2023
PR-URL: #46550 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 20, 2023
Co-authored-by: Daniel Lemire <daniel@lemire.me> PR-URL: #46550 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
danielleadams
added
the
backport-blocked-v18.x
PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport.
label
Apr 3, 2023
Blocked by #46410 |
anonrig
added a commit
to anonrig/node
that referenced
this pull request
Apr 5, 2023
PR-URL: nodejs#46550 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
anonrig
added a commit
to anonrig/node
that referenced
this pull request
Apr 5, 2023
Co-authored-by: Daniel Lemire <daniel@lemire.me> PR-URL: nodejs#46550 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
anonrig
added
backport-open-v18.x
Indicate that the PR has an open backport.
and removed
backport-blocked-v18.x
PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport.
labels
Apr 5, 2023
anonrig
added a commit
to anonrig/node
that referenced
this pull request
Apr 5, 2023
PR-URL: nodejs#46550 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
anonrig
added a commit
to anonrig/node
that referenced
this pull request
Apr 5, 2023
Co-authored-by: Daniel Lemire <daniel@lemire.me> PR-URL: nodejs#46550 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
anonrig
added a commit
to anonrig/node
that referenced
this pull request
Apr 11, 2023
PR-URL: nodejs#46550 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
anonrig
added a commit
to anonrig/node
that referenced
this pull request
Apr 11, 2023
Co-authored-by: Daniel Lemire <daniel@lemire.me> PR-URL: nodejs#46550 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
anonrig
added a commit
to anonrig/node
that referenced
this pull request
Apr 11, 2023
PR-URL: nodejs#46550 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
anonrig
added a commit
to anonrig/node
that referenced
this pull request
Apr 11, 2023
Co-authored-by: Daniel Lemire <daniel@lemire.me> PR-URL: nodejs#46550 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
danielleadams
added
backported-to-v18.x
PRs backported to the v18.x-staging branch.
and removed
backport-open-v18.x
Indicate that the PR has an open backport.
labels
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
backported-to-v18.x
PRs backported to the v18.x-staging branch.
commit-queue-rebase
Add this label to allow the Commit Queue to land a PR in several commits.
dependencies
Pull requests that update a dependency file.
needs-ci
PRs that need a full CI run.
tools
Issues and PRs related to the tools directory.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the bug in
update-ada.sh
script, and updating the file to the latest version.