src: handle wasm out of bound in osx will raise SIGBUS correctly #46561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
addaleax
approved these changes
Feb 8, 2023
addaleax
approved these changes
Feb 8, 2023
github-actions
bot
added
request-ci-failed
Failed to start CI- Validating Jenkins credentials ✖ Jenkins credentials invalidhttps://github.com/nodejs/node/actions/runs/4125736345 |
jasnell
approved these changes
Feb 9, 2023
RaisinTen
approved these changes
Feb 9, 2023
JungMinu
approved these changes
Feb 9, 2023
|
Is it possible to re-run the CI? |
|
CI has been locked down for Feb 14 security releases. |
|
Requested new CI |
github-actions
bot
removed
the
request-ci
This was referenced Mar 3, 2023
aduh95
added
request-ci
github-actions
bot
removed
the
request-ci
This was referenced Mar 10, 2023
This was referenced Jun 11, 2023
|
Could it land now? |
RaisinTen
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/46561 ✔ Done loading data for nodejs/node/pull/46561 ----------------------------------- PR info ------------------------------------ Title src: handle wasm out of bound in osx will raise SIGBUS correctly (#46561) Author Congcong Cai (@HerrCai0907, first-time contributor) Branch HerrCai0907:fix/sigbus-in-mac-wasm -> nodejs:main Labels c++, author ready, commit-queue-squash Commits 4 - src: handle wasm out of bound in osx will raise SIGBUS correctly - format - add TODO mark - Update test/parallel/test-wasm-memory-out-of-bound.js Committers 2 - Congcong Cai - GitHub PR-URL: https://github.com/nodejs/node/pull/46561 Fixes: https://github.com/nodejs/node/issues/46559 Reviewed-By: Anna Henningsen Reviewed-By: James M Snell Reviewed-By: Darshan Sen Reviewed-By: Minwoo Jung Reviewed-By: Michael Dawson ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/46561 Fixes: https://github.com/nodejs/node/issues/46559 Reviewed-By: Anna Henningsen Reviewed-By: James M Snell Reviewed-By: Darshan Sen Reviewed-By: Minwoo Jung Reviewed-By: Michael Dawson -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - Update test/parallel/test-wasm-memory-out-of-bound.js ℹ This PR was created on Wed, 08 Feb 2023 09:50:45 GMT ✔ Approvals: 5 ✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/46561#pullrequestreview-1289424314 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/46561#pullrequestreview-1290258481 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/46561#pullrequestreview-1290656679 ✔ - Minwoo Jung (@JungMinu): https://github.com/nodejs/node/pull/46561#pullrequestreview-1291233080 ✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/46561#pullrequestreview-1457624085 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-06-12T02:27:52Z: https://ci.nodejs.org/job/node-test-pull-request/52216/ - Querying data for job/node-test-pull-request/52216/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/5244996345 |
RaisinTen
approved these changes
Jun 12, 2023
RaisinTen
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in ed92b1f |
22 tasks
This was referenced Jun 14, 2023
29 tasks
RafaelGSS
pushed a commit
that referenced
this pull request
Jul 3, 2023
fix: #46559 OSX will raise both SIGBUS and SIGSEGV when out of bound memory visit, This commit set sigaction in OSX for two signals to handle this. PR-URL: #46561 Fixes: #46559 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Merged
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
fix: nodejs#46559 OSX will raise both SIGBUS and SIGSEGV when out of bound memory visit, This commit set sigaction in OSX for two signals to handle this. PR-URL: nodejs#46561 Fixes: nodejs#46559 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
fix: nodejs#46559 OSX will raise both SIGBUS and SIGSEGV when out of bound memory visit, This commit set sigaction in OSX for two signals to handle this. PR-URL: nodejs#46561 Fixes: nodejs#46559 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
ruyadorno
pushed a commit
that referenced
this pull request
Sep 7, 2023
fix: #46559 OSX will raise both SIGBUS and SIGSEGV when out of bound memory visit, This commit set sigaction in OSX for two signals to handle this. PR-URL: #46561 Fixes: #46559 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Merged
ruyadorno
pushed a commit
that referenced
this pull request
Sep 13, 2023
fix: #46559 OSX will raise both SIGBUS and SIGSEGV when out of bound memory visit, This commit set sigaction in OSX for two signals to handle this. PR-URL: #46561 Fixes: #46559 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #46559
OSX will raise both SIGBUS and SIGSEGV when out of bound memory visit, This commit set sigaction in OSX for two signals to handle this.