Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: add note about clientError event #46584

Merged
merged 1 commit into from
Feb 12, 2023
Merged

http: add note about clientError event #46584

merged 1 commit into from
Feb 12, 2023

Conversation

ShogunPanda
Copy link
Contributor

Add the document that during clientError the socket MUST be closed.

Fixes #43548.

@ShogunPanda ShogunPanda added doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. labels Feb 9, 2023
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023

Fast-track has been requested by @ShogunPanda. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added the http Issues or PRs related to the http subsystem. label Feb 9, 2023
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. and removed fast-track PRs that do not need to wait for 48 hours to land. labels Feb 12, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 12, 2023
@nodejs-github-bot nodejs-github-bot merged commit 331697c into nodejs:main Feb 12, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 331697c

@ShogunPanda ShogunPanda deleted the http-close-on-clienterror branch February 13, 2023 08:44
MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
@ShogunPanda @MylesBorins
http: add note about clientError event
338c8f6 
PR-URL: #46584
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 19, 2023
Merged
MylesBorins pushed a commit that referenced this pull request Feb 20, 2023
@ShogunPanda @MylesBorins
http: add note about clientError event
7f2cdd3 
PR-URL: #46584
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@ShogunPanda @danielleadams
http: add note about clientError event
abeee99 
PR-URL: #46584
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flooding requests results in memory leak
4 participants
@ShogunPanda @nodejs-github-bot @lpinca @aduh95