Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v18.14.2 proposal #46724

Merged
merged 6 commits into from
Feb 21, 2023
Merged

v18.14.2 proposal #46724

merged 6 commits into from
Feb 21, 2023

Conversation

MylesBorins
Copy link
Contributor

2023-02-21, Version 18.14.2 'Hydrogen' (LTS), @MylesBorins

Notable Changes

Commits

targos and others added 5 commits February 16, 2023 18:21
@targos @RafaelGSS
deps: patch V8 to 10.2.154.26
5e1f213 
Refs: v8/v8@10.2.154.23...10.2.154.26
PR-URL: #46446
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@juanarbol @MylesBorins
build: delete snapshot.blob file from the project
880a65d 
The `snapshot.blob` file landed while backporting
2c0f7d4
in the v18.x release line, but is not required

Fixes: #46133
PR-URL: #46626
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@npm-cli-bot @MylesBorins
deps: upgrade npm to 9.4.0
648041d 
PR-URL: #46353
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@npm-cli-bot @MylesBorins
deps: upgrade npm to 9.5.0
f864bef 
PR-URL: #46673
Reviewed-By: Luke Karrys <luke@lukekarrys.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@nodejs-github-bot @MylesBorins
deps: update undici to 5.20.0
cbea56e 
PR-URL: #46711
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@nodejs-github-bot nodejs-github-bot added dont-land-on-v14.x fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. labels Feb 18, 2023
@github-actions

This comment was marked as outdated.

Sign in to view
@MylesBorins MylesBorins added request-ci Add this label to start a Jenkins CI on a PR. and removed fast-track PRs that do not need to wait for 48 hours to land. dont-land-on-v14.x labels Feb 18, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 18, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 18, 2023 •
edited by MylesBorins
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/49718/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/5184/
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3124/
CITGM v18.14.1: https://ci.nodejs.org/job/citgm-smoker/3122/
CITGM v18.14.0: https://ci.nodejs.org/job/citgm-smoker/3084/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5184/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu1804-intel-64,v8test=v8test/5184/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5184/

@aduh95
Copy link
Contributor

aduh95 commented Feb 19, 2023

The commit message of a1a9d91 says "PR-URL: TODO", this would need to be amended I think.

@github-actions github-actions bot mentioned this pull request Feb 20, 2023
Open
24 tasks
@MylesBorins
2023-02-21, Version 18.14.2 'Hydrogen' (LTS)
4df0001 
Notable changes:

deps:
  * upgrade npm to 9.5.0 (npm team) #46673

PR-URL: #46724
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49762/

mcollina
mcollina approved these changes Feb 20, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

juanarbol
juanarbol approved these changes Feb 20, 2023
View reviewed changes
Copy link
Member

@juanarbol juanarbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins
Copy link
Contributor Author

rc.0: https://ci-release.nodejs.org/job/iojs+release/9164/

@github-actions github-actions bot mentioned this pull request Feb 21, 2023
Open
26 tasks
@MylesBorins
Copy link
Contributor Author

Tests are all green and nothing looks odd in CITGM. I'll do one last review of CITGM tomorrow before promoting the release.

@VoltrexKeyva VoltrexKeyva added release Issues and PRs related to Node.js releases. and removed meta Issues and PRs related to the general management of the project. npm Issues and PRs related to the npm client dependency or the npm registry. labels Feb 21, 2023
@MylesBorins
Copy link
Contributor Author

There is a newish failure with torrent-stream on certain *nix boxes but it is failing on 18.14.1 and on 18.4.0

I'm going to move forward with the release

MylesBorins added a commit that referenced this pull request Feb 21, 2023
@MylesBorins
Working on v18.14.3
b266adb 
PR-URL: #46724
@MylesBorins MylesBorins merged commit 4df0001 into v18.x Feb 21, 2023
@MylesBorins MylesBorins deleted the v18.14.2-proposal branch February 21, 2023 18:10
MylesBorins added a commit that referenced this pull request Feb 21, 2023
@MylesBorins
2023-02-21, Version 18.14.2 'Hydrogen' (LTS)
6a80a2b 
Notable changes:

deps:
  * upgrade npm to 9.5.0 (npm team) #46673

PR-URL: #46724
MylesBorins added a commit to nodejs/nodejs.org that referenced this pull request Feb 21, 2023
@MylesBorins
blog: release notes for v19.7.0 and v18.14.2
f1cf24c 
Refs:nodejs/node#46725
Refs: nodejs/node#46724
@MylesBorins MylesBorins mentioned this pull request Feb 21, 2023
Merged
Trott pushed a commit to nodejs/nodejs.org that referenced this pull request Feb 21, 2023
@MylesBorins
blog: release notes for v19.7.0 and v18.14.2 (#5064)
96525c8 
Refs:nodejs/node#46725
Refs: nodejs/node#46724
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@ruyadorno ruyadorno ruyadorno approved these changes

@targos targos targos approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@juanarbol juanarbol juanarbol approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. release Issues and PRs related to Node.js releases. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@MylesBorins @nodejs-github-bot @aduh95 @mcollina @ruyadorno @targos @BethGriggs @juanarbol @VoltrexKeyva @npm-cli-bot