Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add document for profiling and heap snapshot #46787

Merged
merged 1 commit into from
Feb 23, 2023
Merged

doc: add document for profiling and heap snapshot #46787

merged 1 commit into from
Feb 23, 2023

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 22, 2023

@cola119 closed #43018, probably because it had sat for so long without action. I think we should land it. Can folks please take a look? @nodejs/diagnostics

@nodejs-github-bot nodejs-github-bot added debugger Issues and PRs related to the debugger subsystem. doc Issues and PRs related to the documentations. labels Feb 22, 2023
@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 22, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

cola119
cola119 approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@cola119 cola119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your support on my previous pull request.

@cola119 @aduh95
doc: add document for profiling and heap snapshot
5c7b81d 
PR-URL: nodejs#46787
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@aduh95
Copy link
Contributor

aduh95 commented Feb 23, 2023 •
edited
Loading

Landed in 5c7b81d (since the commit was authored by @cola119, I've put @Trott in the list of reviewers instead of him as Rich approved the original PR)

@aduh95 aduh95 merged commit 5c7b81d into nodejs:main Feb 23, 2023
@Trott Trott deleted the doc-update branch February 24, 2023 14:43
targos pushed a commit that referenced this pull request Mar 13, 2023
@cola119 @targos
doc: add document for profiling and heap snapshot
00edc50 
PR-URL: #46787
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@cola119 @danielleadams
doc: add document for profiling and heap snapshot
3dae6f2 
PR-URL: #46787
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@tony-go tony-go tony-go approved these changes

@cola119 cola119 cola119 approved these changes

Assignees
No one assigned
Labels
debugger Issues and PRs related to the debugger subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @aduh95 @cola119 @tony-go @RafaelGSS @nodejs-github-bot