stream: don't read more than can handle in webstream

[rluvaton]

fix #46347

TODO

• add tests? how could I test that the memory usage is not rising? 🤔

---

Cc @mcollina

[rluvaton]

Need to make sure controller.desiredSize must be less than 1GB as the docs specify

[...] The size argument must be less than or equal to 1 GiB. [...]

from readable.read([size]) - Node Docs

[rluvaton]

Should I don't specify size argument here, in case the desiredSize is really big?

[rluvaton]

I think the current behavior in the failing test should be the expected one, why would we need 2 reads?

the failed test is:

node/test/parallel/test-whatwg-webstreams-adapters-to-readablewritablepair.js

Lines 174 to 209 in b164038

	{
	const duplex = new PassThrough();
	const {
	readable,
	writable,
	} = newReadableWritablePairFromDuplex(duplex);
	duplex.on('data', common.mustCall(2));
	duplex.on('close', common.mustCall());
	duplex.on('end', common.mustCall());
	duplex.on('finish', common.mustCall());
	const writer = writable.getWriter();
	const reader = readable.getReader();
	const ec = new TextEncoder();
	const dc = new TextDecoder();
	Promise.all([
	writer.write(ec.encode('hello')),
	reader.read().then(common.mustCall(({ done, value }) => {
	assert(!done);
	assert.strictEqual(dc.decode(value), 'hello');
	})),
	reader.read().then(common.mustCall(({ done, value }) => {
	assert(!done);
	assert.strictEqual(dc.decode(value), 'there');
	})),
	writer.write(ec.encode('there')),
	writer.close(),
	reader.read().then(common.mustCall(({ done, value }) => {
	assert(done);
	assert.strictEqual(value, undefined);
	})),
	]).then(common.mustCall());
	}

[rluvaton]

ping @mcollina

[mcollina]

In don't know. I would need to dig deep into this and currently do not have time. Maybe @jasnell has some ideas.

[mcollina]

lgtm

This is correct but it needs a test

[aduh95]

It looks like this still needs a test.

[github-actions]

This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.

[github-actions]

Closing this because it has stalled. Feel free to reopen if this issue/PR is still relevant, or to ping the collaborator who labelled it stalled if you have any questions.