Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: reduce flakiness of parallel/test-http-remove-header-stays-removed.js #46855

Merged

Conversation

debadree25
Copy link
Member

The test test-http-remove-header-stays-removed.js seems to be slightly flaky as seen in nodejs/reliability#508 and also reproducible locally by running python3 tools/test.py test/parallel/test-http-remove-header-stays-removed.js --repeat 1000

Since the test checks that the socket is closed right after receiving the last chunk of data hence moved the checking for the same after the data has been received and slightly increased the timeout, the flakiness no longer reproduces

Refs: nodejs/reliability#508
Refs: #46333

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Feb 27, 2023
@debadree25 debadree25 force-pushed the ft/improve-test-http-remove-header branch from 37b2da5 to 2c2b37c Compare February 27, 2023 07:34
@debadree25 debadree25 changed the title test: reduce flakiness of test/parallel/test-http-remove-header-stays-removed.js test: reduce flakiness of parallel/test-http-remove-header-stays-removed.js Feb 27, 2023
@debadree25 debadree25 added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Feb 27, 2023
@ronag
Copy link
Member

ronag commented Feb 27, 2023

Does this allow a bug during flakiness?

@debadree25
Copy link
Member Author

Does this allow a bug during flakiness?

Didn't get you? 😅😅

@debadree25 debadree25 added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 28, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 28, 2023
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

@debadree25
Copy link
Member Author

ping @ronag

Co-authored-by: Matteo Collina <matteo.collina@gmail.com>
@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 13, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 13, 2023
@nodejs-github-bot
Copy link
Collaborator

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@debadree25 debadree25 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Mar 16, 2023
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 18, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 18, 2023
@nodejs-github-bot nodejs-github-bot merged commit 9ce2f4f into nodejs:main Mar 18, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 9ce2f4f

RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
Refs: nodejs/reliability#508
Refs: #46333
PR-URL: #46855
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Apr 6, 2023
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
Refs: nodejs/reliability#508
Refs: #46333
PR-URL: #46855
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
Refs: nodejs/reliability#508
Refs: #46333
PR-URL: #46855
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. flaky-test Issues and PRs related to the tests with unstable failures on the CI. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants