-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: reduce flakiness of parallel/test-http-remove-header-stays-removed.js #46855
Merged
nodejs-github-bot
merged 2 commits into
nodejs:main
from
debadree25:ft/improve-test-http-remove-header
Mar 18, 2023
Merged
test: reduce flakiness of parallel/test-http-remove-header-stays-removed.js #46855
nodejs-github-bot
merged 2 commits into
nodejs:main
from
debadree25:ft/improve-test-http-remove-header
Mar 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
labels
Feb 27, 2023
debadree25
force-pushed
the
ft/improve-test-http-remove-header
branch
from
February 27, 2023 07:34
37b2da5
to
2c2b37c
Compare
debadree25
changed the title
test: reduce flakiness of test/parallel/test-http-remove-header-stays-removed.js
test: reduce flakiness of parallel/test-http-remove-header-stays-removed.js
Feb 27, 2023
debadree25
added
the
flaky-test
Issues and PRs related to the tests with unstable failures on the CI.
label
Feb 27, 2023
debadree25
force-pushed
the
ft/improve-test-http-remove-header
branch
from
February 27, 2023 07:36
2c2b37c
to
e0e39c6
Compare
Does this allow a bug during flakiness? |
Didn't get you? 😅😅 |
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Feb 28, 2023
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced Mar 1, 2023
18 tasks
ping @ronag |
mcollina
reviewed
Mar 13, 2023
Co-authored-by: Matteo Collina <matteo.collina@gmail.com>
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Mar 13, 2023
mcollina
approved these changes
Mar 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
debadree25
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
labels
Mar 16, 2023
aduh95
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Mar 18, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Mar 18, 2023
Landed in 9ce2f4f |
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 5, 2023
Refs: nodejs/reliability#508 Refs: #46333 PR-URL: #46855 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 7, 2023
Refs: nodejs/reliability#508 Refs: #46333 PR-URL: #46855 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
Refs: nodejs/reliability#508 Refs: #46333 PR-URL: #46855 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
flaky-test
Issues and PRs related to the tests with unstable failures on the CI.
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test
test-http-remove-header-stays-removed.js
seems to be slightly flaky as seen in nodejs/reliability#508 and also reproducible locally by runningpython3 tools/test.py test/parallel/test-http-remove-header-stays-removed.js --repeat 1000
Since the test checks that the socket is closed right after receiving the last chunk of data hence moved the checking for the same after the data has been received and slightly increased the timeout, the flakiness no longer reproduces
Refs: nodejs/reliability#508
Refs: #46333