Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix test file path in test-permission-deny-fs-symlink-target-write.js #46859

Merged
merged 3 commits into from
Mar 1, 2023
Merged

test: fix test file path in test-permission-deny-fs-symlink-target-write.js #46859

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e81a1e7
test: fix file path in permission symlink test
LiviaMedeiros Feb 27, 2023
46c68a2
squash: Update test/parallel/test-permission-deny-fs-symlink-target-w…
LiviaMedeiros Feb 28, 2023
6c9e68d
squash: fixup
LiviaMedeiros Feb 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions test/parallel/test-permission-deny-fs-symlink-target-write.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,7 @@ fs.writeFileSync(path.join(readWriteFolder, 'file'), 'NO evil file contents');
}));

// App will be able to write to the symlink
fs.writeFile('file', 'some content', (err) => {
assert.ifError(err);
});
fs.writeFile(path.join(writeOnlyFolder, 'link-to-read-write'), 'some content', common.mustSucceed());
});

// App won't be able to symlink to a readOnlyFolder
Expand Down