Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inspector: log response and requests in the inspector for debugging #46941

Merged
merged 2 commits into from
Mar 22, 2023

Conversation

joyeecheung
Copy link
Member

Logs the raw messages from the inspector when NODE_DEBUG_NATIVE is set to inspector_server to facilitate debugging.

Logs the raw messages from the inspector when NODE_DEBUG_NATIVE
is set to inspector_server to facilitate debugging.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol needs-ci PRs that need a full CI run. labels Mar 3, 2023
@joyeecheung
Copy link
Member Author

By the way I am not sure since when we stopped using INSPECTOR_SERVER, but before this patch INSPECTOR_SERVER is otherwise unused.

@nodejs-github-bot
Copy link
Collaborator

src/inspector_agent.cc Outdated Show resolved Hide resolved
src/inspector_agent.cc Outdated Show resolved Hide resolved
…gging

Co-authored-by: Anna Henningsen <github@addaleax.net>
@nodejs-github-bot
Copy link
Collaborator

@joyeecheung joyeecheung added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Mar 17, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 17, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/46941
✔  Done loading data for nodejs/node/pull/46941
----------------------------------- PR info ------------------------------------
Title      inspector: log response and requests in the inspector for debugging (#46941)
Author     Joyee Cheung  (@joyeecheung)
Branch     joyeecheung:inspector-debug -> nodejs:main
Labels     c++, inspector, needs-ci, commit-queue-squash
Commits    2
 - inspector: log response and requests in the inspector for debugging
 - fixup! inspector: log response and requests in the inspector for debu…
Committers 2
 - Joyee Cheung 
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/46941
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/46941
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last review:
   ⚠  - fixup! inspector: log response and requests in the inspector for debu…
   ℹ  This PR was created on Fri, 03 Mar 2023 18:15:18 GMT
   ✘  Approvals: 0
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-03-13T16:29:57Z: https://ci.nodejs.org/job/node-test-pull-request/50357/
- Querying data for job/node-test-pull-request/50357/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/4451496611

@joyeecheung
Copy link
Member Author

cc @nodejs/inspector @nodejs/cpp-reviewers can I have some review please?

Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@joyeecheung joyeecheung added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Mar 22, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 22, 2023
@nodejs-github-bot nodejs-github-bot merged commit 434bdde into nodejs:main Mar 22, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 434bdde

RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
Logs the raw messages from the inspector when NODE_DEBUG_NATIVE
is set to inspector_server to facilitate debugging.

PR-URL: #46941
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Apr 6, 2023
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
Logs the raw messages from the inspector when NODE_DEBUG_NATIVE
is set to inspector_server to facilitate debugging.

PR-URL: #46941
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
Logs the raw messages from the inspector when NODE_DEBUG_NATIVE
is set to inspector_server to facilitate debugging.

PR-URL: #46941
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. inspector Issues and PRs related to the V8 inspector protocol needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants