Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debugger: improve validations and documents for watch and unwatch #46947

Merged

Conversation

Dailyscat
Copy link
Contributor

#42882
#42913

I combined what was reflected in each PR.

  • add information on unwatch(index) command
  • add string validation for watch command

@nodejs-github-bot nodejs-github-bot added debugger Issues and PRs related to the debugger subsystem. needs-ci PRs that need a full CI run. labels Mar 4, 2023
@cola119 cola119 changed the title debugger, doc: Add string validation for watch, add information on unwatch(index) command debugger: Add string validation for watch, add information on unwatch(index) command Mar 5, 2023
@cola119 cola119 added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 5, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 5, 2023
@nodejs-github-bot
Copy link
Collaborator

@cola119 cola119 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 6, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 7, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/46947
✔  Done loading data for nodejs/node/pull/46947
----------------------------------- PR info ------------------------------------
Title      debugger: Add string validation for watch, add information on unwatch(index) command (#46947)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     Dailyscat:add-string-validation-for-watch -> nodejs:main
Labels     author ready, needs-ci, debugger, commit-queue-squash
Commits    4
 - debugger: add string validation for watch(expr)
 - debugger: add help document for watch(index)
 - test: add test for watch(index) command
 - doc: add information on unwatch(index) option
Committers 1
 - eungyu.lee 
PR-URL: https://github.com/nodejs/node/pull/46947
Reviewed-By: Kohei Ueno 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/46947
Reviewed-By: Kohei Ueno 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 04 Mar 2023 10:43:28 GMT
   ✔  Approvals: 1
   ✔  - Kohei Ueno (@cola119): https://github.com/nodejs/node/pull/46947#pullrequestreview-1325303593
   ✖  This PR needs to wait 97 more hours to land (or 0 hours if there is one more approval)
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-03-05T23:52:56Z: https://ci.nodejs.org/job/node-test-pull-request/50217/
- Querying data for job/node-test-pull-request/50217/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/4352354485

@cola119 cola119 removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Mar 7, 2023
@cola119
Copy link
Member

cola119 commented Mar 9, 2023

@Dailyscat Can you squash all commits and update the initial commit message to a more relevant one?

@Dailyscat Dailyscat force-pushed the add-string-validation-for-watch branch from f52a538 to 4b84bc5 Compare March 10, 2023 01:59
@cola119 cola119 added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 10, 2023
@Dailyscat Dailyscat force-pushed the add-string-validation-for-watch branch from 4b84bc5 to b32bffd Compare March 10, 2023 03:53
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 10, 2023
- debugger: add string validation for watch(expr)
- debugger: add help document for watch(index)
- test: add test for watch(index) command
- doc: add information on unwatch(index) option
@Dailyscat Dailyscat force-pushed the add-string-validation-for-watch branch from b32bffd to 28de121 Compare March 10, 2023 03:57
@cola119 cola119 added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 11, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 11, 2023
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@cola119 cola119 changed the title debugger: Add string validation for watch, add information on unwatch(index) command debugger: improve validations and documents for watch and unwatch Mar 12, 2023
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@cola119 cola119 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Mar 13, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 13, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/46947
✔  Done loading data for nodejs/node/pull/46947
----------------------------------- PR info ------------------------------------
Title      debugger: improve validations and documents for watch and unwatch (#46947)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     Dailyscat:add-string-validation-for-watch -> nodejs:main
Labels     author ready, needs-ci, debugger
Commits    1
 - debugger: improve validations and documents for watch and unwatch
Committers 1
 - eungyu.lee 
PR-URL: https://github.com/nodejs/node/pull/46947
Reviewed-By: Kohei Ueno 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/46947
Reviewed-By: Kohei Ueno 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last review:
   ⚠  - debugger: improve validations and documents for watch and unwatch
   ℹ  This PR was created on Sat, 04 Mar 2023 10:43:28 GMT
   ✔  Approvals: 1
   ✔  - Kohei Ueno (@cola119): https://github.com/nodejs/node/pull/46947#pullrequestreview-1325303593
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-03-13T02:22:26Z: https://ci.nodejs.org/job/node-test-pull-request/50343/
- Querying data for job/node-test-pull-request/50343/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/4401209251

@cola119 cola119 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Mar 13, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 13, 2023
@nodejs-github-bot nodejs-github-bot merged commit f8bf498 into nodejs:main Mar 13, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in f8bf498

targos pushed a commit that referenced this pull request Mar 13, 2023
- debugger: add string validation for watch(expr)
- debugger: add help document for watch(index)
- test: add test for watch(index) command
- doc: add information on unwatch(index) option

PR-URL: #46947
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
targos pushed a commit that referenced this pull request Mar 14, 2023
- debugger: add string validation for watch(expr)
- debugger: add help document for watch(index)
- test: add test for watch(index) command
- doc: add information on unwatch(index) option

PR-URL: #46947
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
- debugger: add string validation for watch(expr)
- debugger: add help document for watch(index)
- test: add test for watch(index) command
- doc: add information on unwatch(index) option

PR-URL: #46947
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. debugger Issues and PRs related to the debugger subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants