Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update OpenSSL to 3.0.8-quic1 #46957

Closed
wants to merge 2 commits into from
Closed

deps: update OpenSSL to 3.0.8-quic1 #46957

wants to merge 2 commits into from

Conversation

nodejs-github-bot
Copy link
Collaborator

This is an automated update of OpenSSL to 3.0.8-quic1.

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency. labels Mar 5, 2023
@marco-ippolito
Copy link
Member

@RafaelGSS this the new action from #45605

@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 6, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 6, 2023
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/50219/

@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/50220/

@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 6, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 6, 2023
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/50222/

RafaelGSS
RafaelGSS requested changes Mar 6, 2023
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marco-ippolito We're already using OpenSSL 3.0.8+quic. I think there's a mistake in the version checker.

This was referenced Mar 7, 2023
Open
Open
Open
Open
Open
@marco-ippolito marco-ippolito mentioned this pull request Apr 3, 2023
Merged
nodejs-github-bot pushed a commit that referenced this pull request Apr 5, 2023
@marco-ippolito
tools: fix update-openssl.yml compare version
069365c 
PR-URL: #47384
Refs: #46957
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
@marco-ippolito @RafaelGSS
tools: fix update-openssl.yml compare version
90c98d0 
PR-URL: #47384
Refs: #46957
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
@marco-ippolito @RafaelGSS
tools: fix update-openssl.yml compare version
669fe78 
PR-URL: #47384
Refs: #46957
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@tniessen
Copy link
Member

tniessen commented Apr 6, 2023

@marco-ippolito should this be closed?

@marco-ippolito
Copy link
Member

yes it has been fixed

@richardlau richardlau deleted the actions/tools-update-openssl branch April 6, 2023 13:29
RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023
@marco-ippolito @RafaelGSS
tools: fix update-openssl.yml compare version
4ee4c7f 
PR-URL: #47384
Refs: #46957
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
@marco-ippolito @RafaelGSS
tools: fix update-openssl.yml compare version
0a766e4 
PR-URL: #47384
Refs: #46957
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 8, 2023
@marco-ippolito @RafaelGSS
tools: fix update-openssl.yml compare version
a65fe5c 
PR-URL: #47384
Refs: #46957
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 13, 2023
@marco-ippolito @RafaelGSS
tools: fix update-openssl.yml compare version
24e334b 
PR-URL: #47384
Refs: #46957
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@marco-ippolito @danielleadams
tools: fix update-openssl.yml compare version
cd43ddf 
PR-URL: #47384
Refs: #46957
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@marco-ippolito @MoLow
tools: fix update-openssl.yml compare version
f27680e 
PR-URL: nodejs#47384
Refs: nodejs#46957
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafaelGSS RafaelGSS RafaelGSS requested changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nodejs-github-bot @marco-ippolito @tniessen @RafaelGSS @anonrig