Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node: allow preload modules with -i #4696

Merged
merged 1 commit into from
Jan 18, 2016
Merged

Conversation

evanlucas
Copy link
Contributor

This gives us the ability to preload when using the node repl. This can
be useful for doing things like creating aliases.

@mscdex mscdex added the lib / src Issues and PRs related to general changes in the lib or src directory. label Jan 14, 2016
@jasnell jasnell added the semver-minor PRs that contain new features and should be released in the next minor version. label Jan 14, 2016
@Fishrock123
Copy link
Contributor

I think there was an issue for this. Will take a look tomorrow.

@Fishrock123
Copy link
Contributor

fixes: #4661

@@ -0,0 +1,5 @@
global.a = 'test';
process.stdin.on('data', function(chunk) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just ran this locally without this block of code and it still passed. Are you sure this is needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange, it wasn't working for me. The process never ended until I added this. I'll take another look though

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, you were right. Not sure why I was getting that issue. Updated

@cjihrig
Copy link
Contributor

cjihrig commented Jan 15, 2016

LGTM with a few comments.

@evanlucas
Copy link
Contributor Author

@evanlucas
Copy link
Contributor Author

Updated to fix requested changes. PTAL

@cjihrig
Copy link
Contributor

cjihrig commented Jan 18, 2016

LGTM.

There were Jenkins issues in the last run. Trying the CI again: https://ci.nodejs.org/job/node-test-pull-request/1291/

@jasnell
Copy link
Member

jasnell commented Jan 18, 2016

Buildbot failure in CI, otherwise green. LGTM

This gives us the ability to preload when using the node repl. This can
be useful for doing things like creating aliases.

Fixes: nodejs#4661
PR-URL: nodejs#4696
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@evanlucas
Copy link
Contributor Author

Landed in ff64a4c. Thanks!

@evanlucas evanlucas merged commit ff64a4c into nodejs:master Jan 18, 2016
evanlucas added a commit that referenced this pull request Jan 18, 2016
This gives us the ability to preload when using the node repl. This can
be useful for doing things like creating aliases.

Fixes: #4661
PR-URL: #4696
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas added a commit that referenced this pull request Jan 20, 2016
Notable changes:

* events: make sure console functions exist (Dave) #4479
* fs: add autoClose option to fs.createWriteStream (Saquib) #3679
* http: improves expect header handling (Daniel Sellers) #4501
* node: allow preload modules with -i (Evan Lucas) #4696
* v8,src: expose statistics about heap spaces (`v8.getHeapSpaceStatistics()`) (Ben Ripkens) #4463
* Minor performance improvements:
  - lib: Use arrow functions instead of bind where possible (Minwoo Jung) #3622
  - module: cache stat() results more aggressively (Ben Noordhuis) #4575
  - querystring: improve parse() performance (Brian White) #4675

PR-URL: #4742
evanlucas added a commit that referenced this pull request Jan 21, 2016
Notable changes:

* events: make sure console functions exist (Dave) #4479
* fs: add autoClose option to fs.createWriteStream (Saquib) #3679
* http: improves expect header handling (Daniel Sellers) #4501
* node: allow preload modules with -i (Evan Lucas) #4696
* v8,src: expose statistics about heap spaces (`v8.getHeapSpaceStatistics()`) (Ben Ripkens) #4463
* Minor performance improvements:
  - lib: Use arrow functions instead of bind where possible (Minwoo Jung) #3622
  - module: cache stat() results more aggressively (Ben Noordhuis) #4575
  - querystring: improve parse() performance (Brian White) #4675

PR-URL: #4742
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
This gives us the ability to preload when using the node repl. This can
be useful for doing things like creating aliases.

Fixes: nodejs#4661
PR-URL: nodejs#4696
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
Notable changes:

* events: make sure console functions exist (Dave) nodejs#4479
* fs: add autoClose option to fs.createWriteStream (Saquib) nodejs#3679
* http: improves expect header handling (Daniel Sellers) nodejs#4501
* node: allow preload modules with -i (Evan Lucas) nodejs#4696
* v8,src: expose statistics about heap spaces (`v8.getHeapSpaceStatistics()`) (Ben Ripkens) nodejs#4463
* Minor performance improvements:
  - lib: Use arrow functions instead of bind where possible (Minwoo Jung) nodejs#3622
  - module: cache stat() results more aggressively (Ben Noordhuis) nodejs#4575
  - querystring: improve parse() performance (Brian White) nodejs#4675

PR-URL: nodejs#4742
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lib / src Issues and PRs related to general changes in the lib or src directory. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants