test_runner: support handling errors from outside of tests #46962

cjihrig · 2023-03-05T18:28:57Z

test_runner: give the root test a harness reference

This commit replaces the 'coverage' reference inside of the Test
class with a more generic harness reference which includes
coverage. This will let the root test more easily track process
level state such as code coverage, uncaughtException handlers,
and the state of bootstrapping.

test_runner: track bootstrapping process

This commit updates the test harness and root test to track
when bootstrapping has completed.

test_runner: throw if harness is not bootstrapped

This commit updates the test harness to re-throw uncaught errors
if bootstrapping has not completed. This updates the existing
logic which tried to detect a specific error code.

test_runner: handle errors not bound to tests

This commit addresses a previously untested branch of the code.
It is possible when using the test runner that an error occurs
outside of a test. In this case, the test runner would simply
rethrow the error. This commit updates the logic to handle the
error in the same fashion as other uncaughtExceptions.

nodejs-github-bot · 2023-03-05T18:29:02Z

Review requested:

@nodejs/test_runner

lib/internal/test_runner/utils.js

test/message/test_runner_output.out

lib/internal/test_runner/harness.js

shrujalshah28 · 2023-03-06T12:21:10Z

This will also need the dont-land-on-v14.x label

nodejs-github-bot · 2023-03-06T16:05:10Z

CI: https://ci.nodejs.org/job/node-test-pull-request/50230/

cjihrig · 2023-03-07T14:52:26Z

Not sure why the bot didn't post a comment, but here is the passing CI run: https://ci.nodejs.org/job/node-test-pull-request/50240/

This commit replaces the 'coverage' reference inside of the Test class with a more generic harness reference which includes coverage. This will let the root test more easily track process level state such as code coverage, uncaughtException handlers, and the state of bootstrapping. PR-URL: nodejs#46962 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

This commit updates the test harness and root test to track when bootstrapping has completed. PR-URL: nodejs#46962 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

This commit updates the test harness to re-throw uncaught errors if bootstrapping has not completed. This updates the existing logic which tried to detect a specific error code. PR-URL: nodejs#46962 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

This commit addresses a previously untested branch of the code. It is possible when using the test runner that an error occurs outside of a test. In this case, the test runner would simply rethrow the error. This commit updates the logic to handle the error in the same fashion as other uncaughtExceptions. PR-URL: nodejs#46962 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

cjihrig · 2023-03-07T19:01:28Z

Landed in b191f09, 4e3bc06, e079aa8, and 3d63d53.

richardlau · 2023-03-07T19:01:59Z

Not sure why the bot didn't post a comment, but here is the passing CI run: https://ci.nodejs.org/job/node-test-pull-request/50240/

The bot was broken by a dependency update: nodejs/github-bot#376

This commit replaces the 'coverage' reference inside of the Test class with a more generic harness reference which includes coverage. This will let the root test more easily track process level state such as code coverage, uncaughtException handlers, and the state of bootstrapping. PR-URL: #46962 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

This commit updates the test harness and root test to track when bootstrapping has completed. PR-URL: #46962 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

This commit updates the test harness to re-throw uncaught errors if bootstrapping has not completed. This updates the existing logic which tried to detect a specific error code. PR-URL: #46962 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

This commit addresses a previously untested branch of the code. It is possible when using the test runner that an error occurs outside of a test. In this case, the test runner would simply rethrow the error. This commit updates the logic to handle the error in the same fashion as other uncaughtExceptions. PR-URL: #46962 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>