Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esm: fix import assertion warning #46971

Merged
merged 2 commits into from
Mar 7, 2023
Merged

esm: fix import assertion warning #46971

merged 2 commits into from
Mar 7, 2023

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Mar 6, 2023

@aduh95 aduh95 added experimental Issues and PRs related to experimental features. fast-track PRs that do not need to wait for 48 hours to land. labels Mar 6, 2023
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/modules

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

Fast-track has been requested by @aduh95. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Mar 6, 2023
GeoffreyBooth
GeoffreyBooth approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@GeoffreyBooth GeoffreyBooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 6, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 6, 2023
@aduh95

This comment was marked as outdated.

Sign in to view
@aduh95
Copy link
Contributor Author

aduh95 commented Mar 6, 2023 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/50243/ 💛

@github-actions github-actions bot mentioned this pull request Mar 7, 2023
Open
19 tasks
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 7, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 7, 2023
@nodejs-github-bot nodejs-github-bot merged commit 0c4f8f2 into nodejs:main Mar 7, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 0c4f8f2

@aduh95 aduh95 deleted the import-assertion-runtime-warning branch March 7, 2023 10:33
This was referenced Mar 8, 2023
Open
Open
This was referenced Mar 10, 2023
Open
Open
Open
targos pushed a commit that referenced this pull request Mar 13, 2023
@aduh95 @targos
esm: fix import assertion warning
40f13eb 
Refs: #46901 (comment)
PR-URL: #46971
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Mar 14, 2023
@aduh95 @targos
esm: fix import assertion warning
9d4d916 
Refs: #46901 (comment)
PR-URL: #46971
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@aduh95 @danielleadams
esm: fix import assertion warning
5b94e2b 
Refs: #46901 (comment)
PR-URL: #46971
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

@lpinca lpinca lpinca approved these changes

@JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes

@MoLow MoLow MoLow approved these changes

@aymen94 aymen94 aymen94 approved these changes

@debadree25 debadree25 debadree25 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. esm Issues and PRs related to the ECMAScript Modules implementation. experimental Issues and PRs related to experimental features. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@aduh95 @nodejs-github-bot @ljharb @GeoffreyBooth @lpinca @JakobJingleheimer @MoLow @aymen94 @debadree25