Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: automate cares update #46993

Merged
merged 6 commits into from
Mar 10, 2023
Merged

tools: automate cares update #46993

merged 6 commits into from
Mar 10, 2023

Conversation

marco-ippolito
Copy link
Member

@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Mar 7, 2023
@aduh95
Copy link
Contributor

aduh95 commented Mar 7, 2023

Would you be interested in doing something similar to what was done in #46488 by @tony-go? If not, no problem, it can be done in a follow-up PR.

@marco-ippolito
Copy link
Member Author

marco-ippolito commented Mar 7, 2023 •
edited
Loading

Would you be interested in doing something similar to what was done in #46488 by @tony-go? If not, no problem, it can be done in a follow-up PR.

yes! I moved cares to the new folder, will update it like in the pr you linked.
I'll open a new pr to update all other scripts.

tony-go
tony-go approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@tony-go tony-go left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@marco-ippolito @richardlau
fix: typo
8ed3876 
Co-authored-by: Richard Lau <rlau@redhat.com>
anonrig
anonrig reviewed Mar 7, 2023
View reviewed changes
tools/dep_updaters/update-cares.sh Outdated Show resolved Hide resolved
tools/dep_updaters/update-cares.sh Outdated Show resolved Hide resolved
tools/dep_updaters/update-cares.sh Outdated Show resolved Hide resolved
@marco-ippolito @aduh95
fix: curl
3c68f46 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 8, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 8, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50279/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50286/

@marco-ippolito marco-ippolito added commit-queue Add this label to land a pull request using GitHub Actions. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 9, 2023
@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Mar 10, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 10, 2023
@nodejs-github-bot nodejs-github-bot merged commit 3591728 into nodejs:main Mar 10, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 3591728

targos pushed a commit that referenced this pull request Mar 13, 2023
@marco-ippolito @targos
tools: automate cares update
49a5c03 
PR-URL: #46993
Refs: nodejs/security-wg#828
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos pushed a commit that referenced this pull request Mar 14, 2023
@marco-ippolito @targos
tools: automate cares update
2e7ba31 
PR-URL: #46993
Refs: nodejs/security-wg#828
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@targos targos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@marco-ippolito @danielleadams
tools: automate cares update
a3f272e 
PR-URL: #46993
Refs: nodejs/security-wg#828
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau left review comments

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@tony-go tony-go tony-go approved these changes

@aduh95 aduh95 aduh95 approved these changes

@anonrig anonrig anonrig approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@marco-ippolito @aduh95 @nodejs-github-bot @benjamingr @anonrig @richardlau @tony-go @RafaelGSS