Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: Return on UV_ENOSYS in GetInterfaceAddresses. #4703

Closed

Conversation

bryce-gibson
Copy link

When using SUNOS_NO_IFADDRS (on Solaris 10, for context) libuv returns -ENOSYS.

When that error is seen this method sets the response to the error code, but continues processing.

This leads to a segfault in uv_free_interface_addresses. Instead, just return as there is no need to process the rest of the function (afaict?)

@bryce-gibson
Copy link
Author

Ah, just found 028194b.

Could it be applied to the 4.x branch?

@cjihrig
Copy link
Contributor

cjihrig commented Jan 14, 2016

The PR that provided that commit is #4272. It has been tagged to backport to 4.x already.

@cjihrig cjihrig closed this Jan 14, 2016
@bryce-gibson
Copy link
Author

Oh, apologies, should've looked closer.

Thanks :-)

@cjihrig
Copy link
Contributor

cjihrig commented Jan 14, 2016

Thanks for the contribution anyway :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants