-
-
Notifications
You must be signed in to change notification settings - Fork 34k
events: add getMaxListeners method #47039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nodejs-github-bot
merged 4 commits into
nodejs:main
from
KhafraDev:events-getmaxlisteners
Mar 19, 2023
Merged
events: add getMaxListeners method #47039
nodejs-github-bot
merged 4 commits into
nodejs:main
from
KhafraDev:events-getmaxlisteners
Mar 19, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debadree25
approved these changes
Mar 12, 2023
Member
|
also cc'ing @nodejs/events |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
20 tasks
This comment was marked as outdated.
This comment was marked as outdated.
Member
|
I think this would qualify as semver-minor too? since adding a new api hence added the label |
benjamingr
reviewed
Mar 13, 2023
benjamingr
approved these changes
Mar 13, 2023
24 tasks
This comment was marked as outdated.
This comment was marked as outdated.
22 tasks
22 tasks
debadree25
reviewed
Mar 16, 2023
This comment was marked as off-topic.
This comment was marked as off-topic.
This was referenced Mar 20, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
events
Issues and PRs related to the events subsystem / EventEmitter.
needs-ci
PRs that need a full CI run.
semver-minor
PRs that contain new features and should be released in the next minor version.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an
events.getMaxListenersmethod that both EventEmitter & EventTarget can use. Currently, there isn't a way to get the max listeners for an EventTarget.Undici currently increases AbortSignal's max listeners because 10 is too conservative for fetch. However someone might increase this limit, which we override. Using this we can detect if the limit's been changed, and not set our own default if it has.
Refs: nodejs/undici#1910 (comment)