Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_runner: accept \x1b as a escape symbol #47050

Merged
merged 2 commits into from
Mar 16, 2023

Conversation

debadree25
Copy link
Member

It seems that TAPLexer was throwing an error on the ANSI code \x1b hence added the same as a escape symbol

Fixes: #46959

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@debadree25 debadree25 requested a review from MoLow March 12, 2023 11:02
@nodejs-github-bot nodejs-github-bot added dont-land-on-v14.x needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Mar 12, 2023
Copy link
Member

@MoLow MoLow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@debadree25 debadree25 added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 12, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 12, 2023
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

@debadree25 debadree25 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 12, 2023
@MoLow MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 15, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 15, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/47050
✔  Done loading data for nodejs/node/pull/47050
----------------------------------- PR info ------------------------------------
Title      test_runner: accept \x1b as a escape symbol (#47050)
Author     Debadree Chatterjee  (@debadree25)
Branch     debadree25:ft/tap-lexer-ansi-escape -> nodejs:main
Labels     author ready, needs-ci, dont-land-on-v14.x, test_runner
Commits    2
 - test_runner: accept \x1b as a escape symbol
 - fixup! space
Committers 1
 - Debadree Chatterjee 
PR-URL: https://github.com/nodejs/node/pull/47050
Fixes: https://github.com/nodejs/node/issues/46959
Reviewed-By: Moshe Atlow 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/47050
Fixes: https://github.com/nodejs/node/issues/46959
Reviewed-By: Moshe Atlow 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 12 Mar 2023 11:01:47 GMT
   ✔  Approvals: 1
   ✔  - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/47050#pullrequestreview-1336012293
   ✘  This PR needs to wait 86 more hours to land (or 0 hours if there is one more approval)
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-03-12T14:21:21Z: https://ci.nodejs.org/job/node-test-pull-request/50335/
- Querying data for job/node-test-pull-request/50335/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/4430846114

@debadree25
Copy link
Member Author

would need another review to land

@debadree25 debadree25 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Mar 16, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 16, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/47050
✔  Done loading data for nodejs/node/pull/47050
----------------------------------- PR info ------------------------------------
Title      test_runner: accept \x1b as a escape symbol (#47050)
Author     Debadree Chatterjee  (@debadree25)
Branch     debadree25:ft/tap-lexer-ansi-escape -> nodejs:main
Labels     author ready, needs-ci, dont-land-on-v14.x, test_runner
Commits    2
 - test_runner: accept \x1b as a escape symbol
 - fixup! space
Committers 1
 - Debadree Chatterjee 
PR-URL: https://github.com/nodejs/node/pull/47050
Fixes: https://github.com/nodejs/node/issues/46959
Reviewed-By: Moshe Atlow 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/47050
Fixes: https://github.com/nodejs/node/issues/46959
Reviewed-By: Moshe Atlow 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 12 Mar 2023 11:01:47 GMT
   ✔  Approvals: 2
   ✔  - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/47050#pullrequestreview-1336012293
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/47050#pullrequestreview-1344628705
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-03-15T20:55:54Z: https://ci.nodejs.org/job/node-test-pull-request/50335/
- Querying data for job/node-test-pull-request/50335/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 47050
From https://github.com/nodejs/node
 * branch                  refs/pull/47050/merge -> FETCH_HEAD
✔  Fetched commits as 8713c83462df..52c773d3e481
--------------------------------------------------------------------------------
[main 3955686063] test_runner: accept \x1b as a escape symbol
 Author: Debadree Chatterjee 
 Date: Sun Mar 12 16:28:02 2023 +0530
 2 files changed, 13 insertions(+), 1 deletion(-)
[main 9b2bdf9330] fixup! space
 Author: Debadree Chatterjee 
 Date: Sun Mar 12 16:28:34 2023 +0530
 1 file changed, 1 insertion(+), 1 deletion(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)

Executing: git node land --amend --yes
⚠ Found Fixes: #46959, skipping..
--------------------------------- New Message ----------------------------------
test_runner: accept \x1b as a escape symbol

Fixes: #46959
PR-URL: #47050
Reviewed-By: Moshe Atlow moshe@atlow.co.il
Reviewed-By: Luigi Pinca luigipinca@gmail.com

[detached HEAD a3e046675b] test_runner: accept \x1b as a escape symbol
Author: Debadree Chatterjee debadree333@gmail.com
Date: Sun Mar 12 16:28:02 2023 +0530
2 files changed, 13 insertions(+), 1 deletion(-)
Rebasing (3/4)
Rebasing (4/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
fixup! space

PR-URL: #47050
Fixes: #46959
Reviewed-By: Moshe Atlow moshe@atlow.co.il
Reviewed-By: Luigi Pinca luigipinca@gmail.com

[detached HEAD 21df468a86] fixup! space
Author: Debadree Chatterjee debadree333@gmail.com
Date: Sun Mar 12 16:28:34 2023 +0530
1 file changed, 1 insertion(+), 1 deletion(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/4441310390

@MoLow MoLow added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Mar 16, 2023
@MoLow MoLow added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Mar 16, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 16, 2023
@nodejs-github-bot nodejs-github-bot merged commit d51541b into nodejs:main Mar 16, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in d51541b

targos pushed a commit that referenced this pull request Mar 18, 2023
Fixes: #46959
PR-URL: #47050
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
Fixes: #46959
PR-URL: #47050
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test runner breaks with ERR_TAP_LEXER_ERROR while trying a console.dir with colors flag set ( {colors: true} )
4 participants