src: fix clang 14 linker error #47057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
Compiling with clang 14 on Ubuntu was failing with a linker error that `node::MaybeStackBuffer::AllocateSufficientStorage` was undefined in `src/inspector/node_string.cc`. I bisected it to the referenced PR. Include `util-inl.h` which defines `node::MaybeStackBuffer::AllocateSufficientStorage`. Refs: nodejs#46817
github-actions
bot
removed
the
request-ci
VoltrexKeyva
approved these changes
Mar 13, 2023
anonrig
approved these changes
Mar 13, 2023
anonrig
added
the
author ready
RaisinTen
approved these changes
Mar 13, 2023
lpinca
approved these changes
Mar 13, 2023
tniessen
approved these changes
Mar 13, 2023
anonrig
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 85d6140 |
targos
pushed a commit
that referenced
this pull request
Mar 18, 2023
Compiling with clang 14 on Ubuntu was failing with a linker error that `node::MaybeStackBuffer::AllocateSufficientStorage` was undefined in `src/inspector/node_string.cc`. I bisected it to the referenced PR. Include `util-inl.h` which defines `node::MaybeStackBuffer::AllocateSufficientStorage`. Refs: #46817 PR-URL: #47057 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This was referenced Apr 3, 2023
Merged
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
Compiling with clang 14 on Ubuntu was failing with a linker error that `node::MaybeStackBuffer::AllocateSufficientStorage` was undefined in `src/inspector/node_string.cc`. I bisected it to the referenced PR. Include `util-inl.h` which defines `node::MaybeStackBuffer::AllocateSufficientStorage`. Refs: #46817 PR-URL: #47057 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiling with clang 14 on Ubuntu was failing with a linker error that
node::MaybeStackBuffer::AllocateSufficientStoragewas undefined insrc/inspector/node_string.cc. I bisected it to the referenced PR.Add the missing
util-inl.hinclude.Refs: #46817