test: fix test-permission-deny-fs-wildcard (win32) #47095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test fails on Windows when the working directory is not on a 'C:' drive. For example, it always fails during the coverage-windows GitHub action, which runs tests on drive 'D:'. Fixes: nodejs#47093
nodejs-github-bot
added
needs-ci
|
Does it need fast-track? |
I don't think that's strictly necessary; while the test fails during coverage-windows, the coverage jobs seem to ignore test outcomes, and Jenkins uses the |
lpinca
approved these changes
Mar 14, 2023
Not sure if this is the cause of this test failing on the Windows on arm64 CI: #47020 |
tniessen
added
fast-track
|
Fast-track has been requested by @tniessen. Please 👍 to approve. |
|
@richardlau I don't know either, but I'll propose fast-tracking and we'll see. |
github-actions
bot
removed
the
request-ci
cjihrig
approved these changes
Mar 14, 2023
MoLow
approved these changes
Mar 14, 2023
tniessen
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 1cfe058 |
anonrig
approved these changes
Mar 15, 2023
RafaelGSS
added
backport-blocked-v16.x
backport-blocked-v18.x
RafaelGSS
added
dont-land-on-v16.x
dont-land-on-v18.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test fails on Windows when the working directory is not on a 'C:' drive. For example, it always fails during the coverage-windows GitHub action, which runs tests on drive 'D:'.
Fixes: #47093