tools: automate brotli update #47205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
meta
anonrig
reviewed
Mar 21, 2023
marco-ippolito
changed the title
marco-ippolito
force-pushed
the
feat/automate-brotli-update
branch
from
1bcb492
to
efc3c43
Compare
UlisesGascon
approved these changes
Mar 22, 2023
edsadr
approved these changes
Mar 22, 2023
Do you mean that when updated Node.js will no longer have those files? They still existing in the main branch of brotli so them being removed does not make sense to me. |
|
This is where I see them still existing in the upstream - https://github.com/google/brotli/tree/master/c/common |
|
@mhdawson they are not present in the c/common folder of the release zip/tar.gz, which is odd |
marco-ippolito
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in da8c099 |
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 5, 2023
PR-URL: #47205 Refs: nodejs/security-wg#828 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Adrian Estrada <edsadr@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 6, 2023
PR-URL: #47205 Refs: nodejs/security-wg#828 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Adrian Estrada <edsadr@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 7, 2023
PR-URL: #47205 Refs: nodejs/security-wg#828 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Adrian Estrada <edsadr@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 8, 2023
PR-URL: #47205 Refs: nodejs/security-wg#828 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Adrian Estrada <edsadr@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
PR-URL: #47205 Refs: nodejs/security-wg#828 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Adrian Estrada <edsadr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: nodejs/security-wg#828
This is the first attempt to automate brotli update.
These two files get deleted by the update, maybe we should save them?
https://github.com/nodejs/node/blob/main/deps/brotli/c/common/dictionary.bin.br
https://github.com/nodejs/node/blob/main/deps/brotli/c/common/dictionary.bin
@nodejs/security-wg