Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cherry-pick eslint update to v4.x #4721

Closed
wants to merge 6 commits into from
Closed

cherry-pick eslint update to v4.x #4721

wants to merge 6 commits into from

Commits on Jan 16, 2016

  1. gitignore: never ignore debug module 

    On case-insensitive platorms, the Debug/ rule catches the debug module
under npm and eslint.

PR-URL: nodejs#2286
Reviewed-By: Roman Reiss <me@silverwind.io>
    @targos
    targos committed Jan 16, 2016
    Configuration menu
    Copy the full SHA
    0be87c6 View commit details
    Browse the repository at this point in the history

  2. tools: update eslint to v1.10.3 

    PR-URL: nodejs#2286
Reviewed-By: Roman Reiss <me@silverwind.io>
    @targos
    targos committed Jan 16, 2016
    Configuration menu
    Copy the full SHA
    ce926e4 View commit details
    Browse the repository at this point in the history

  3. tools: update eslint config 

    The no-reserved-keys rule doesn't exist anymore and we don't need ES3
compatibility.
escape and unescape are now known by eslint.
--reset flag was removed and it is now the default behavior.

PR-URL: nodejs#2286
Reviewed-By: Roman Reiss <me@silverwind.io>
    @targos
    targos committed Jan 16, 2016
    Configuration menu
    Copy the full SHA
    81252ae View commit details
    Browse the repository at this point in the history

  4. lib: fix style issues after eslint update 

    With an indentation style of two spaces, it is not possible to indent
multiline variable declarations by four spaces. Instead, the var keyword
is used on every new line.
Use const instead of var where applicable for changed lines.

PR-URL: nodejs#2286
Reviewed-By: Roman Reiss <me@silverwind.io>
    @targos
    targos committed Jan 16, 2016
    Configuration menu
    Copy the full SHA
    a36e881 View commit details
    Browse the repository at this point in the history

  5. tools: fix style issue after eslint update 

    PR-URL: nodejs#2286
Reviewed-By: Roman Reiss <me@silverwind.io>
    @targos
    targos committed Jan 16, 2016
    Configuration menu
    Copy the full SHA
    cbdd1d1 View commit details
    Browse the repository at this point in the history

  6. test: fix style issues after eslint update 

    Replace var keyword with const or let.

PR-URL: nodejs#2286
Reviewed-By: Roman Reiss <me@silverwind.io>
    @targos
    targos committed Jan 16, 2016
    Configuration menu
    Copy the full SHA
    f0fae32 View commit details
    Browse the repository at this point in the history