Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove useless WPT init scripts #47221

Closed
wants to merge 1 commit into from
Closed

test: remove useless WPT init scripts #47221

wants to merge 1 commit into from

Conversation

KhafraDev
Copy link
Member

File is now a global so the init scripts are no longer needed.

Refs: #47153 (review)

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 22, 2023
@panva panva mentioned this pull request Mar 22, 2023
Closed
@panva panva added dont-land-on-v14.x dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 22, 2023
@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 22, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 22, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50559/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50561/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50596/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50617/

@panva
Copy link
Member

panva commented Mar 28, 2023

Landed in 9dfd039

@panva panva closed this Mar 28, 2023
panva pushed a commit that referenced this pull request Mar 28, 2023
@KhafraDev @panva
test: remove useless WPT init scripts
9dfd039 
PR-URL: #47221
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@KhafraDev KhafraDev deleted the useless-wpt-initscripts branch March 28, 2023 14:39
@github-actions github-actions bot mentioned this pull request Mar 30, 2023
Open
18 tasks
@RafaelGSS RafaelGSS mentioned this pull request Apr 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

@panva panva panva approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KhafraDev @nodejs-github-bot @panva @lpinca @anonrig