Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update timezone to 2023b #47256

Merged
merged 1 commit into from
Mar 28, 2023
Merged

deps: update timezone to 2023b #47256

merged 1 commit into from
Mar 28, 2023

Conversation

nodejs-github-bot
Copy link
Collaborator

This PR was generated by tools/timezone-update.yml.

Updates the ICU files as per the instructions present in https://github.com/nodejs/node/blob/main/doc/contributing/maintaining-icu.md#time-zone-data

To test, build node off this branch & log the version of tz using

console.log(process.versions.tz)

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Mar 26, 2023
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 26, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 26, 2023
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/50605/

@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/50607/

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 26, 2023
@merceyz merceyz mentioned this pull request Mar 27, 2023
Closed
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 28, 2023
@nodejs-github-bot nodejs-github-bot merged commit 67200dc into main Mar 28, 2023
@nodejs-github-bot nodejs-github-bot deleted the actions/timezone-update branch March 28, 2023 00:49
@nodejs-github-bot
Copy link
Collaborator Author

Landed in 67200dc

@targos targos mentioned this pull request Mar 28, 2023
Merged
@richardlau
Copy link
Member

cc @nodejs/releasers
So it seems that 2023b was for "Lebanon delays the start of DST this year": https://mm.icann.org/pipermail/tz-announce/2023-March/000078.html
However it sounds like this decision has been reversed, (there's a lot of chatter on https://mm.icann.org/pipermail/tz/2023-March/thread.html) and for now users should either stick to 2023a or wait for 2023c. https://mm.icann.org/pipermail/tz/2023-March/032833.html

@targos targos added backport-blocked-v14.x backport-blocked-v18.x PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport. labels Mar 28, 2023
@github-actions github-actions bot mentioned this pull request Mar 30, 2023
Open
18 tasks
@RafaelGSS RafaelGSS mentioned this pull request Apr 3, 2023
Merged
@richardlau richardlau removed backport-blocked-v18.x PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport. backport-blocked-v19.x labels Apr 6, 2023
@richardlau
Copy link
Member

Removing the backport-blocked labels as #47302 has fixed the incorrect timezone that this update included. The commit from this PR needs to land so that #47302 can land cleanly on the staging branches.

RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023
@nodejs-github-bot @RafaelGSS
deps: update timezone to 2023b
03e8673 
PR-URL: #47256
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@RafaelGSS RafaelGSS mentioned this pull request Apr 6, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
@nodejs-github-bot @RafaelGSS
deps: update timezone to 2023b
a3ea0ae 
PR-URL: #47256
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
RafaelGSS pushed a commit that referenced this pull request Apr 8, 2023
@nodejs-github-bot @RafaelGSS
deps: update timezone to 2023b
30c043c 
PR-URL: #47256
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@nodejs-github-bot @danielleadams
deps: update timezone to 2023b
fc6ab26 
PR-URL: #47256
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nodejs-github-bot @richardlau @lpinca @anonrig @targos