Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: skip instantiateStreaming-bad-imports WPT #47292

Merged
merged 1 commit into from
Mar 29, 2023
Merged

test: skip instantiateStreaming-bad-imports WPT #47292

merged 1 commit into from
Mar 29, 2023

Conversation

targos
Copy link
Member

@targos targos commented Mar 29, 2023

This test is flaky on ARM with V8 >= 11.2.
Skip it so we can update V8 before the release of Nodejs 20.0.0.

Refs: #46815 and #47251

@targos
test: skip instantiateStreaming-bad-imports WPT
a9188e8 
This test is flaky on ARM with V8 >= 11.2.
Skip it so we can update V8 before the release of Nodejs 20.0.0.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 29, 2023
@targos
Copy link
Member Author

targos commented Mar 29, 2023

/cc @nodejs/v8-update @nodejs/tsc

MoLow
MoLow approved these changes Mar 29, 2023
View reviewed changes
Copy link
Member

@MoLow MoLow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@targos targos added fast-track PRs that do not need to wait for 48 hours to land. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 29, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @targos. Please 👍 to approve.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 29, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50658/

@panva
Copy link
Member

panva commented Mar 29, 2023 •
edited
Loading

Is it flaky, or just out right failing/hanging to a point where you want to skip it everywhere?

If just flaky, the flaky test names may just be added like so

{
  "instantiateStreaming-bad-imports.any.js": {
    "fail": {
      "note": "You may leave an optional arbitrary note e.g. with TODOs",
      "flaky": [
        "flaky test name"
      ]
    }
  }
}

If it's hanging, we need to look into the running properly handling such cases.

If you want to skip them on a particular build or configuration, there's no way to do that today, but we could revive #45826 (comment) to be able to do this type of skipping/flaky declaration.

@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 29, 2023
@targos
Copy link
Member Author

targos commented Mar 29, 2023

It is hanging but not 100% of the runs. Either it passes or it hangs.

@panva
Copy link
Member

panva commented Mar 29, 2023

It is hanging but not 100% of the runs. Either it passes or it hangs.

Let's skip then but open an issue to investigate why the runner can't deal with it.

@RafaelGSS
Copy link
Member

RafaelGSS commented Mar 29, 2023 •
edited
Loading

It is hanging but not 100% of the runs. Either it passes or it hangs.

Let's skip then but open an issue to investigate why the runner can't deal with it.

We can open a revert PR after landing V8 update on main.

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 29, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 29, 2023
@nodejs-github-bot nodejs-github-bot merged commit 3cf65bd into nodejs:main Mar 29, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 3cf65bd

@targos targos deleted the skip-wasm-webapi branch March 29, 2023 11:58
This was referenced Mar 29, 2023
Closed
Open
@RafaelGSS RafaelGSS mentioned this pull request Apr 3, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
@targos @RafaelGSS
test: skip instantiateStreaming-bad-imports WPT
3c49422 
This test is flaky on ARM with V8 >= 11.2.
Skip it so we can update V8 before the release of Nodejs 20.0.0.

PR-URL: #47292
Refs: #46815
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Apr 6, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023
@targos @RafaelGSS
test: skip instantiateStreaming-bad-imports WPT
f8dd97e 
This test is flaky on ARM with V8 >= 11.2.
Skip it so we can update V8 before the release of Nodejs 20.0.0.

PR-URL: #47292
Refs: #46815
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
@targos @RafaelGSS
test: skip instantiateStreaming-bad-imports WPT
567573b 
This test is flaky on ARM with V8 >= 11.2.
Skip it so we can update V8 before the release of Nodejs 20.0.0.

PR-URL: #47292
Refs: #46815
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@targos @danielleadams
test: skip instantiateStreaming-bad-imports WPT
b620f5f 
This test is flaky on ARM with V8 >= 11.2.
Skip it so we can update V8 before the release of Nodejs 20.0.0.

PR-URL: #47292
Refs: #46815
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@debadree25 debadree25 debadree25 approved these changes

@MoLow MoLow MoLow approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@tniessen tniessen tniessen approved these changes

@panva panva panva approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@targos @nodejs-github-bot @panva @RafaelGSS @tniessen @gengjiawen @MoLow @debadree25 @RaisinTen