Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quic: do not dereference shared_ptr after move #47294

Closed
wants to merge 1 commit into from
Closed

quic: do not dereference shared_ptr after move #47294

wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

The stored pointer is assumed to be nullptr after std::move.

@tniessen
quic: do not dereference shared_ptr after move
c1e8758 
The stored pointer is assumed to be nullptr after std::move.
@tniessen tniessen added c++ Issues and PRs that require attention from people who are familiar with C++. quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Mar 29, 2023
@tniessen tniessen requested a review from jasnell March 29, 2023 12:08
@nodejs-github-bot nodejs-github-bot added dont-land-on-v14.x needs-ci PRs that need a full CI run. labels Mar 29, 2023
jasnell
jasnell reviewed Mar 29, 2023
View reviewed changes
src/quic/data.cc
CHECK_LE(offset_, store->ByteLength());
CHECK_LE(length_, store->ByteLength() - offset_);
CHECK_LE(offset_, store_->ByteLength());
CHECK_LE(length_, store_->ByteLength() - offset_);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh! ha, good catch.

@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 29, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @jasnell. Please 👍 to approve.

@jasnell jasnell requested review from anonrig and Qard March 29, 2023 13:27
@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 29, 2023
@jasnell jasnell removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 29, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50664/

@jasnell
Copy link
Member

jasnell commented Mar 29, 2023

Landed in 9b104be

jasnell pushed a commit that referenced this pull request Mar 29, 2023
@tniessen @jasnell
quic: do not dereference shared_ptr after move
9b104be 
The stored pointer is assumed to be nullptr after std::move.

PR-URL: #47294
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@jasnell jasnell closed this Mar 29, 2023
@RafaelGSS RafaelGSS mentioned this pull request Apr 3, 2023
Merged
@RafaelGSS RafaelGSS added dont-land-on-v16.x dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. labels Apr 5, 2023
@RafaelGSS
Copy link
Member

This PR depends on #47263 which was flagged as "dont-land-on-v19.x". Therefore, I'm adding the dont-land-x labels here too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@jasnell jasnell jasnell approved these changes

@Qard Qard Awaiting requested review from Qard

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tniessen @nodejs-github-bot @jasnell @RafaelGSS @anonrig