-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
permission: drop process.permission.deny #47335
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
Issues and PRs that require attention from people who are familiar with C++.
lib / src
Issues and PRs related to general changes in the lib or src directory.
needs-ci
PRs that need a full CI run.
labels
Mar 31, 2023
RafaelGSS
force-pushed
the
drop-permission-deny
branch
from
March 31, 2023 10:53
4aff6eb
to
19aacdd
Compare
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Mar 31, 2023
RafaelGSS
force-pushed
the
drop-permission-deny
branch
from
March 31, 2023 15:21
19aacdd
to
f779526
Compare
jasnell
approved these changes
Mar 31, 2023
38 tasks
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Apr 1, 2023
aduh95
approved these changes
Apr 1, 2023
Seemingly related CI failures on Windows. |
30 tasks
Yes, I'll fix it today |
RafaelGSS
force-pushed
the
drop-permission-deny
branch
from
April 2, 2023 19:11
f779526
to
ea8d2dd
Compare
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Apr 2, 2023
RafaelGSS
force-pushed
the
drop-permission-deny
branch
from
April 2, 2023 21:28
ea8d2dd
to
2096325
Compare
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Apr 2, 2023
28 tasks
RafaelGSS
force-pushed
the
drop-permission-deny
branch
from
April 3, 2023 13:08
2096325
to
84ad3bc
Compare
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Apr 3, 2023
This was referenced Apr 3, 2023
BethGriggs
approved these changes
Apr 3, 2023
marco-ippolito
approved these changes
Apr 3, 2023
29 tasks
RafaelGSS
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Apr 4, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Apr 4, 2023
Landed in 6fd147c |
RafaelGSS
added
backport-blocked-v16.x
backport-blocked-v18.x
PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport.
labels
Apr 4, 2023
26 tasks
RafaelGSS
added a commit
that referenced
this pull request
Apr 13, 2023
PR-URL: #47335 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@RafaelGSS is there an issue tracking getting this change backported? |
Permission Model is only available on Node.js 20. There's no backport. |
RafaelGSS
added
dont-land-on-v16.x
dont-land-on-v18.x
PRs that should not land on the v18.x-staging branch and should not be released in v18.x.
and removed
backport-blocked-v16.x
backport-blocked-v18.x
PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport.
labels
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c++
Issues and PRs that require attention from people who are familiar with C++.
dont-land-on-v18.x
PRs that should not land on the v18.x-staging branch and should not be released in v18.x.
lib / src
Issues and PRs related to general changes in the lib or src directory.
needs-ci
PRs that need a full CI run.
permission
Issues and PRs related to the Permission Model
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed previously in #47105 and #47269. We're dropping the
process.permission.deny
API to reduce the surface for a potential attack vector.This feature isn't out of our plans, however, we reached a consensus to remove it for further discussion. Also note that this PR isn't a
semver-major
since the feature (permission model) wasn't released yet.