Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quic: add more quic implementation details (part 3) #47348

Closed
wants to merge 4 commits into from
Closed

quic: add more quic implementation details (part 3) #47348

wants to merge 4 commits into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Mar 31, 2023 •
edited
Loading

  • BindingData -- The BindingData object that will be used for the internalBinding('quic') built-in
  • LogStream -- A utility used to provide streaming QLog and KeyLog data
  • TransportParams -- A utility to simplify working with ngtcp2_transport_params

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp

@jasnell jasnell requested a review from tniessen March 31, 2023 17:11
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Mar 31, 2023
@jasnell jasnell requested review from Qard and anonrig March 31, 2023 17:11
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
anonrig
anonrig reviewed Mar 31, 2023
View reviewed changes
src/quic/defs.h Show resolved Hide resolved
src/quic/defs.h Outdated Show resolved Hide resolved
src/quic/logstream.h Show resolved Hide resolved
src/quic/transportparams.h Outdated Show resolved Hide resolved
anonrig
anonrig reviewed Mar 31, 2023
View reviewed changes
src/quic/defs.h Outdated Show resolved Hide resolved
@jasnell jasnell requested a review from anonrig March 31, 2023 19:16
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot mentioned this pull request Apr 2, 2023
Open
30 tasks
This was referenced Apr 3, 2023
Open
Open
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 9, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell
Copy link
Member Author

jasnell commented Apr 10, 2023

Ugh. Not sure why test-child-process-can-write-to-stdout is failing consistently on Mac here.

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 10, 2023 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/51112/ 💚 finally!

jasnell added a commit that referenced this pull request Apr 10, 2023
@jasnell
quic: add more QUIC impl
2d1934a 
* add BindingData
* add LogStream
* add TransportParams

PR-URL: #47348
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
@jasnell
Copy link
Member Author

jasnell commented Apr 10, 2023

Landed in 2d1934a

@jasnell jasnell closed this Apr 10, 2023
@RafaelGSS RafaelGSS mentioned this pull request Apr 11, 2023
Merged
This was referenced Apr 12, 2023
Open
Open
RafaelGSS pushed a commit that referenced this pull request Apr 13, 2023
@jasnell @RafaelGSS
quic: add more QUIC impl
f8b4e26 
* add BindingData
* add LogStream
* add TransportParams

PR-URL: #47348
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@jasnell @danielleadams
quic: add more QUIC impl
406b2b7 
* add BindingData
* add LogStream
* add TransportParams

PR-URL: #47348
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@jasnell @MoLow
quic: add more QUIC impl
2484083 
* add BindingData
* add LogStream
* add TransportParams

PR-URL: nodejs#47348
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@Qard Qard Qard approved these changes

@tniessen tniessen Awaiting requested review from tniessen

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jasnell @nodejs-github-bot @Qard @anonrig