src: make AliasedBuffers in the binding data weak #47354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
joyeecheung
force-pushed
the
aliased-buffer-weak
branch
2 times, most recently
from
994c28e
to
51e1b26
Compare
joyeecheung
force-pushed
the
aliased-buffer-weak
branch
2 times, most recently
from
ebc51a9
to
fa8189f
Compare
joyeecheung
force-pushed
the
aliased-buffer-weak
branch
from
fa8189f
to
2d99c77
Compare
This was referenced Apr 2, 2023
The binding data holds references to the AliasedBuffers directly from their wrappers which already ensures that the AliasedBuffers won't be accessed when the wrappers are GC'ed. So we can just make the global references to the AliasedBuffers weak. This way we can simply deserialize the typed arrays when deserialize the binding data and avoid the extra Object::Set() calls. It also eliminates the caveat in the JS land where aliased buffers must be dynamically read from the binding.
joyeecheung
force-pushed
the
aliased-buffer-weak
branch
from
7b9a1ef
to
540c37f
Compare
|
It's not immediately clear if this will impact the new |
It makes some BindingData included in the default bootstrap weak to at least not leak in shadow realms. For other BindingData it's not strictly necessary but it's a good practice. |
legendecas
approved these changes
Apr 13, 2023
legendecas
added
author ready
nodejs-github-bot
removed
the
commit-queue
|
Landed in b68cedd |
targos
pushed a commit
that referenced
this pull request
May 2, 2023
The binding data holds references to the AliasedBuffers directly from their wrappers which already ensures that the AliasedBuffers won't be accessed when the wrappers are GC'ed. So we can just make the global references to the AliasedBuffers weak. This way we can simply deserialize the typed arrays when deserialize the binding data and avoid the extra Object::Set() calls. It also eliminates the caveat in the JS land where aliased buffers must be dynamically read from the binding. PR-URL: #47354 Refs: #47353 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
danielleadams
added
the
backport-requested-v18.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src: make AliasedBuffers in the binding data weak
The binding data holds references to the AliasedBuffers directly
from their wrappers which already ensures that the AliasedBuffers
won't be accessed when the wrappers are GC'ed. So we can just
make the global references to the AliasedBuffers weak. This way
we can simply deserialize the typed arrays when deserialize the
binding data and avoid the extra Object::Set() calls. It also
eliminates the caveat in the JS land where aliased buffers must
be dynamically read from the binding.
Refs: #47353
(This doesn't fix #47353, but it makes sense on its own, and at least reduces the number of unnecessary global references...)