Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: reserve 116 for Electron 25 #47375

Merged
merged 2 commits into from
Apr 3, 2023
Merged

doc: reserve 116 for Electron 25 #47375

merged 2 commits into from
Apr 3, 2023

Conversation

VerteDinde
Copy link
Contributor

This PR reserves NMV 116 for Electron 25.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 2, 2023
@VerteDinde VerteDinde mentioned this pull request Apr 2, 2023
Merged
5 tasks
@VerteDinde VerteDinde changed the title chore: reserve 116 for Electron 25 doc: reserve 116 for Electron 25 Apr 2, 2023
@anonrig
Copy link
Member

anonrig commented Apr 3, 2023

@VerteDinde Can you update your commit message according to the Commit Message Guidelines? https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines

@VerteDinde
Copy link
Contributor Author

@anonrig Done! Thanks for the review!

@VerteDinde @targos
doc: correct variant
b7ee50a 
Co-authored-by: Michaël Zasso <targos@protonmail.com>
@richardlau richardlau added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Apr 3, 2023
@anonrig anonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 3, 2023
@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

Fast-track has been requested by @targos. Please 👍 to approve.

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 3, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 3, 2023
@nodejs-github-bot nodejs-github-bot merged commit a00137e into nodejs:main Apr 3, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in a00137e

@targos targos added dont-land-on-v14.x dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. labels Apr 3, 2023
@VerteDinde VerteDinde deleted the patch-3 branch April 3, 2023 22:25
@RafaelGSS RafaelGSS mentioned this pull request Apr 11, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 13, 2023
@VerteDinde @RafaelGSS
doc: reserve 116 for Electron 25
f131cca 
PR-URL: #47375
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@targos targos targos approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@VerteDinde @anonrig @nodejs-github-bot @lpinca @targos @richardlau