readline: refactor construct Interface #4740

JacksonTian · 2016-01-18T10:01:35Z

Remove the dependency on the arguments.length.

jasnell · 2016-01-18T16:34:59Z

CI: https://ci.nodejs.org/job/node-test-pull-request/1296/

jasnell · 2016-01-18T16:36:22Z

I hadn't noticed the Interface constructor before... what an odd way of initializing the object... this change looks good but let's see what CI says :-)

cjihrig · 2016-01-18T16:41:35Z

LGTM

jasnell · 2016-01-22T04:53:31Z

CI failures look unrelated. LGTM

TooTallNate · 2016-01-22T04:55:56Z

I'm pretty sure it was related to backwards compat with a really old node version (0.6?). Definitely safe to remove at this point.

jasnell · 2016-03-22T00:19:02Z

New CI: https://ci.nodejs.org/job/node-test-pull-request/2006/

MylesBorins · 2016-06-17T22:34:02Z

ci: https://ci.nodejs.org/job/node-test-pull-request/3021/ (rebased against master)

@nodejs/collaborators PTAL

cjihrig · 2016-06-20T14:28:05Z

LGTM. Let's try another CI: https://ci.nodejs.org/job/node-test-pull-request/3034/

MylesBorins · 2016-07-05T17:41:03Z

one more CI. Will land later today if green https://ci.nodejs.org/job/node-test-pull-request/3178/

rmg · 2016-07-05T20:02:05Z

lib/readline.js

  }

  this._sawReturn = false;

  EventEmitter.call(this);
  var historySize;

-  if (arguments.length === 1) {
+  if (input && input.input) {


Is this change in behaviour intentional? If input is a custom implementation that happens to have an input property, then it will cause the remaining arguments to be ignored. Can we find a safer way replicating the arguments length check? Maybe the ugly/obvious if (input && !output && !completer && !terminal) approach would be the most appropriate?

thanks @rmg for scoping that out

thoughts @nodejs/collaborators?

Hmm, why not just keep arguments.length check?

arguments.length wouldn't work with the way createInterface() was refactored - it now always passes 4 args, even if they're undefined.

How about changing it then to

exports.createInterface = (...args) => new Interface(...args);

?

That should solve the problem and, at the same time, still looks clean and elegant IMO.

Same should be applied for the constructor though, but not hard to do.

facepalm
this is targeting master, so I guess that's an option. Would also match lib/console.js, now that I look.

In fact, given that Interface allows calling itself without new (and unless I'm missing something), it might be even reduced to exports.createInterface = Interface; (in which case I don't really see why two separate methods are exported, unless we want to move Interface to proper ES6 class and effectively break compatibility by forbidding calls without new in future).

no. It doesn't change the behaviour. if (input && input.input) { is used for check first argument is options object.

Remove the dependency on the arguments.length.

jasnell · 2017-01-06T19:14:45Z

@MylesBorins @JacksonTian ... still want this? Looks like it fell through the cracks

JacksonTian · 2017-01-09T01:44:34Z

Yes.

JacksonTian · 2017-01-13T14:54:54Z

landed in dad98bf thanks all.

Remove the dependency on the arguments.length. PR-URL: #4740 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

Remove the dependency on the arguments.length. PR-URL: nodejs#4740 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

Remove the dependency on the arguments.length. PR-URL: #4740 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

MylesBorins · 2017-03-08T01:39:42Z

I've gone ahead and landed this into lts staging. Please let me know if it should be taken out

Remove the dependency on the arguments.length. PR-URL: #4740 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

silverwind added the readline Issues and PRs related to the built-in readline module. label Jan 18, 2016

jasnell added the lts-watch-v4.x label Jan 22, 2016

JacksonTian force-pushed the readline branch from 84c510e to a038a8a Compare March 23, 2016 14:22

estliberitas force-pushed the master branch 2 times, most recently from 7da4fd4 to c7066fb Compare April 26, 2016 05:22

MylesBorins self-assigned this Jun 17, 2016

rmg reviewed Jul 5, 2016
View reviewed changes

Trott force-pushed the master branch from b0df363 to c5ce7f4 Compare September 21, 2016 00:09

rvagg force-pushed the master branch 2 times, most recently from c133999 to 83c7a88 Compare October 18, 2016 17:01

readline: refactor construct Interface

c4a12c8

Remove the dependency on the arguments.length.

JacksonTian force-pushed the readline branch from a038a8a to c4a12c8 Compare December 12, 2016 15:28

nodejs-github-bot added the lts-watch-v6.x label Dec 12, 2016

jasnell added the stalled Issues and PRs that are stalled. label Jan 6, 2017

trevnorris approved these changes Jan 11, 2017

View reviewed changes

benjamingr approved these changes Jan 11, 2017

View reviewed changes

JacksonTian closed this Jan 13, 2017

italoacasas mentioned this pull request Jan 25, 2017

Proposal to update v7.x-staging #10989

Closed

italoacasas mentioned this pull request Jan 29, 2017

v7.5.0 proposal #11062

Merged

MylesBorins added land-on-v4.x and removed lts-watch-v4.x stalled Issues and PRs that are stalled. labels Mar 8, 2017

MylesBorins mentioned this pull request Mar 9, 2017

v6.10.1 proposal #11759

Merged

MylesBorins mentioned this pull request Mar 9, 2017

v4.8.1 proposal #11760

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

readline: refactor construct Interface #4740

readline: refactor construct Interface #4740

JacksonTian commented Jan 18, 2016

jasnell commented Jan 18, 2016

jasnell commented Jan 18, 2016

cjihrig commented Jan 18, 2016

jasnell commented Jan 22, 2016

TooTallNate commented Jan 22, 2016

jasnell commented Mar 22, 2016

MylesBorins commented Jun 17, 2016

cjihrig commented Jun 20, 2016

MylesBorins commented Jul 5, 2016 •

edited

Loading

rmg Jul 5, 2016

MylesBorins Jul 5, 2016 •

edited

Loading

RReverser Jul 5, 2016

rmg Jul 6, 2016

RReverser Jul 6, 2016

RReverser Jul 6, 2016

rmg Jul 6, 2016

RReverser Jul 6, 2016 •

edited

Loading

JacksonTian Dec 12, 2016

jasnell commented Jan 6, 2017

JacksonTian commented Jan 9, 2017

JacksonTian commented Jan 13, 2017

MylesBorins commented Mar 8, 2017

readline: refactor construct Interface #4740

readline: refactor construct Interface #4740

Conversation

JacksonTian commented Jan 18, 2016

jasnell commented Jan 18, 2016

jasnell commented Jan 18, 2016

cjihrig commented Jan 18, 2016

jasnell commented Jan 22, 2016

TooTallNate commented Jan 22, 2016

jasnell commented Mar 22, 2016

MylesBorins commented Jun 17, 2016

cjihrig commented Jun 20, 2016

MylesBorins commented Jul 5, 2016 • edited Loading

rmg Jul 5, 2016

Choose a reason for hiding this comment

MylesBorins Jul 5, 2016 • edited Loading

Choose a reason for hiding this comment

RReverser Jul 5, 2016

Choose a reason for hiding this comment

rmg Jul 6, 2016

Choose a reason for hiding this comment

RReverser Jul 6, 2016

Choose a reason for hiding this comment

RReverser Jul 6, 2016

Choose a reason for hiding this comment

rmg Jul 6, 2016

Choose a reason for hiding this comment

RReverser Jul 6, 2016 • edited Loading

Choose a reason for hiding this comment

JacksonTian Dec 12, 2016

Choose a reason for hiding this comment

jasnell commented Jan 6, 2017

JacksonTian commented Jan 9, 2017

JacksonTian commented Jan 13, 2017

MylesBorins commented Mar 8, 2017

MylesBorins commented Jul 5, 2016 •

edited

Loading

MylesBorins Jul 5, 2016 •

edited

Loading

RReverser Jul 6, 2016 •

edited

Loading