-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
url: more sophisticated brand check for URLSearchParams #47414
Conversation
Review requested:
|
This comment was marked as outdated.
This comment was marked as outdated.
Results are very good IMO:
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
The performance impact might be because Also since this PR doesn't change the status quo, I propose that we not block it on the resolution from #47218. |
This comment was marked as outdated.
This comment was marked as outdated.
Use private properties and static {} blocks. PR-URL: nodejs#47414 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Landed in 4b448c8 |
Use private properties and static {} blocks. PR-URL: #47414 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Use private properties, following the lead of the
URL
class.