Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: mark test/parallel/test-file-write-stream4 as flaky #47423

Merged
merged 1 commit into from
Apr 10, 2023
Merged

test: mark test/parallel/test-file-write-stream4 as flaky #47423

merged 1 commit into from
Apr 10, 2023

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Apr 5, 2023

a mitigation for #47420

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 5, 2023
@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 5, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 5, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50974/

@anonrig anonrig requested a review from richardlau April 5, 2023 16:25
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50988/

@anonrig anonrig force-pushed the test-file-write-flaky branch from 4db3e4d to 1ff9fec Compare April 5, 2023 21:29
@anonrig anonrig requested a review from richardlau April 5, 2023 21:29
@anonrig anonrig force-pushed the test-file-write-flaky branch from 1ff9fec to 2b6588d Compare April 5, 2023 21:30
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@gengjiawen gengjiawen added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

Fast-track has been requested by @gengjiawen. Please 👍 to approve.

@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 6, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 6, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50995/

@targos
Copy link
Member

targos commented Apr 6, 2023

#47450 should make this unnecessary.

@anonrig
Copy link
Member Author

anonrig commented Apr 7, 2023

The Github Workflow results are buggy again. Can someone land this manually?

@MoLow
Copy link
Member

MoLow commented Apr 7, 2023

@anonrig you can land manually as well. Run git node land 47423

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51054/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51071/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51081/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51090/

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 10, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 10, 2023
@nodejs-github-bot nodejs-github-bot merged commit 08e1564 into nodejs:main Apr 10, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 08e1564

@RafaelGSS RafaelGSS mentioned this pull request Apr 11, 2023
Merged
This was referenced Apr 12, 2023
Open
Open
RafaelGSS pushed a commit that referenced this pull request Apr 13, 2023
@anonrig @RafaelGSS
test: mark test/parallel/test-file-write-stream4 as flaky
a5a5d2f 
PR-URL: #47423
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@anonrig @danielleadams
test: mark test/parallel/test-file-write-stream4 as flaky
17b5999 
PR-URL: #47423
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@anonrig @MoLow
test: mark test/parallel/test-file-write-stream4 as flaky
914f68d 
PR-URL: nodejs#47423
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

@richardlau richardlau richardlau approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@anonrig @nodejs-github-bot @targos @MoLow @Trott @gengjiawen @richardlau @VoltrexKeyva